Percona Server moved to https://jira.percona.com/projects/PS

Merge lp:~laurynas-biveinis/percona-server/bug766266-5.1 into lp:percona-server/5.1

  1. bug766266-5.1
  2. Merge into 5.1
Proposed by Laurynas Biveinis
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 269
Proposed branch: lp:~laurynas-biveinis/percona-server/bug766266-5.1
Merge into: lp:percona-server/5.1
Diff against target: 12 lines (+1/-1)
1 file modified
userstat.patch (+1/-1)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug766266-5.1
Reviewer Review Type Date Requested Status
Percona developers Pending
Review via email: mp+69233@code.launchpad.net

Description of the change

Fixes LP bug #766266: the compiler warning:

handler/ha_innodb.cc:4952: error: comparison of unsigned expression >= 0 is always true

The unsigned expression is variable active_index, the fix is trivial.

The Jenkins results are at http://jenkins.percona.com/view/Percona%20Server%205.1/job/percona-server-5.1-param/85/ , incorrectly shown as if everything has failed.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'userstat.patch'
2--- userstat.patch 2011-07-20 03:48:37 +0000
3+++ userstat.patch 2011-07-26 09:46:38 +0000
4@@ -3259,7 +3259,7 @@
5 error = 0;
6 table->status = 0;
7 + rows_read++;
8-+ if (active_index >= 0 && active_index < MAX_KEY)
9++ if (active_index < MAX_KEY)
10 + index_rows_read[active_index]++;
11
12 } else if (ret == DB_RECORD_NOT_FOUND) {

Subscribers

People subscribed via source and target branches