Merge lp:~laurynas-biveinis/percona-server/bug1404565 into lp:percona-server/5.6

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 722
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1404565
Merge into: lp:percona-server/5.6
Diff against target: 19 lines (+0/-9)
1 file modified
storage/innobase/srv/srv0srv.cc (+0/-9)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1404565
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+245570@code.launchpad.net

Description of the change

Fix bug 1404565 (SHOW ENGINE INNODB STATUS has two TRANSACTIONS
sections).

The bug is caused by a merge regression in the initial 5.6 port:
XtraDB moves the transaction section to the end of status output, but
the merge failed to remove it from its original location.

The patch to move the transaction section to the end of status output
originates from Google patches for 5.0.37. The purpose of the patch is
to provide useful InnoDB status output in the case of very long
transaction list that would not fit into 64KB that is the maximum
possible result set length in that version. Since then, the maximum
status output limit has been raised to 1MB
(http://bugs.mysql.com/bug.php?id=56922). Given this and that we
haven't received any truncated status issue reports while we were
printing the transaction list even twice in the output, remove the
Google patch bit and leave the transaction list in its upstream
location.

http://jenkins.percona.com/job/percona-server-5.6-param/788/

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storage/innobase/srv/srv0srv.cc'
2--- storage/innobase/srv/srv0srv.cc 2014-12-01 07:53:48 +0000
3+++ storage/innobase/srv/srv0srv.cc 2015-01-05 12:19:47 +0000
4@@ -1559,15 +1559,6 @@
5 srv_n_rows_deleted_old = srv_stats.n_rows_deleted;
6 srv_n_rows_read_old = srv_stats.n_rows_read;
7
8- /* Only if lock_print_info_summary proceeds correctly,
9- before we call the lock_print_info_all_transactions
10- to print all the lock information. */
11- ret = lock_print_info_summary(file, nowait);
12-
13- if (ret) {
14- lock_print_info_all_transactions(file);
15- }
16-
17 fputs("----------------------------\n"
18 "END OF INNODB MONITOR OUTPUT\n"
19 "============================\n", file);

Subscribers

People subscribed via source and target branches