Percona Server moved to https://jira.percona.com/projects/PS

lp:~laurynas-biveinis/percona-server/bug1387951

Created by Laurynas Biveinis on 2015-02-04 and last modified on 2015-02-04

Get this branch:: bzr branch lp:~laurynas-biveinis/percona-server/bug1387951

Only Laurynas Biveinis can upload to this branch. If you are Laurynas Biveinis please log in for upload directions.

Branch merges

Merged into lp:percona-server/5.6 at revision 736

Laurynas Biveinis (community): Approve on 2015-02-04

Related bugs

Bug #1387951: SET STATEMENT ... FOR <statement> crashes server if <statement> is RW in a RO transaction	High	Fix Released
Bug #1412423: SET STATEMENT ... FOR <statement> crashes server if <statement> needs to re-open a temp table and fails	High	Fix Released
Bug #1418049: SET STATEMENT ... FOR <statement> crashes server if <statement> needs to commit implicitly and fails	High	Fix Released

Link a bug report

Related blueprints

Branch information

Owner:: Laurynas Biveinis

Project:: Percona Server moved to https://jira.percona.com/projects/PS

Status:: Merged

Recent revisions

735. By Laurynas Biveinis on 2015-02-04

Fix SET STATEMENT ... FOR <statement> crashes:
1) if <statement> needs to commit implicitly and fails (bug 1418049);
2) if <statement> is RW in a RO transaction (bug 1387951);
3) if <statement> is needs to reopen a temp table and fails (bug 1412423).

All three bugs are related and caused by mysql_execute_command jumping
over to an error exit (one goto per each bug) and thus skipping
per_query_variables_backup variable initialization. But the cleanup of
restoring thd->variables from the uninitialzied variable still
happened. Fixed trivially.

This bug was also indicated by a compilation warning:

07:37:58 /home/jenkins/workspace/percona-server-5.6-debian-binary-32/label_exp/debian6-32/percona-server-5.6-5.6.22-71.0/sql/sql_parse.cc: In function 'int mysql_execute_command(THD*)':
07:37:58
/home/jenkins/workspace/percona-server-5.6-debian-binary-32/label_exp/debian6-32/percona-server-5.6-5.6.22-71.0/sql/sql_parse.cc:2609:
error: 'per_query_variables_backup' may be used uninitialized in this
function