lp:~laurynas-biveinis/percona-server/bug1387951
- Get this branch:
- bzr branch lp:~laurynas-biveinis/percona-server/bug1387951
Branch merges
- Laurynas Biveinis (community): Approve on 2015-02-04
-
Diff: 150 lines (+82/-6)3 files modifiedmysql-test/r/percona_statement_set.result (+29/-2)
mysql-test/t/percona_statement_set.test (+48/-2)
sql/sql_parse.cc (+5/-2)
Related bugs
Related blueprints
Branch information
- Owner:
- Laurynas Biveinis
- Status:
- Merged
Recent revisions
- 735. By Laurynas Biveinis on 2015-02-04
-
Fix SET STATEMENT ... FOR <statement> crashes:
1) if <statement> needs to commit implicitly and fails (bug 1418049);
2) if <statement> is RW in a RO transaction (bug 1387951);
3) if <statement> is needs to reopen a temp table and fails (bug 1412423).All three bugs are related and caused by mysql_execute_
command jumping
over to an error exit (one goto per each bug) and thus skipping
per_query_variables_ backup variable initialization. But the cleanup of
restoring thd->variables from the uninitialzied variable still
happened. Fixed trivially.This bug was also indicated by a compilation warning:
07:37:58 /home/jenkins/
workspace/ percona- server- 5.6-debian- binary- 32/label_ exp/debian6- 32/percona- server- 5.6-5.6. 22-71.0/ sql/sql_ parse.cc: In function 'int mysql_execute_ command( THD*)':
07:37:58
/home/jenkins/workspace/ percona- server- 5.6-debian- binary- 32/label_ exp/debian6- 32/percona- server- 5.6-5.6. 22-71.0/ sql/sql_ parse.cc: 2609:
error: 'per_query_variables_ backup' may be used uninitialized in this
functionfixing which is part of bug 1408232.
Added testcases.
- 733. By Laurynas Biveinis on 2015-01-30
-
Automerge lp:~laurynas-biveinis/percona-server/bug1415843-5.6
- 730. By Jenkins Master <email address hidden> on 2015-01-22
-
Merge lp:~hrvojem/percona-server/bug1406482-5.6
http://jenkins. percona. com/job/ merge-PS- 5.6-docs- kickoff/ 72/ - 729. By Laurynas Biveinis on 2015-01-14
-
Automerge lp:~vlad-lesin/percona-server/5.6-gtid-deployment-step
- 727. By Laurynas Biveinis on 2015-01-14
-
Automerge lp:~percona-core/percona-server/release-5.6.22-71.0
- 726. By Jenkins Master <email address hidden> on 2015-01-12
-
Merge lp:~hrvojem/percona-server/rn-5.6.22-71.0-5.6
http://jenkins. percona. com/job/ merge-PS- 5.6-docs- kickoff/ 71/
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:percona-server/5.6