Merge lp:~laurynas-biveinis/percona-server/bug1382336-5.6 into lp:percona-server/5.6

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 682
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1382336-5.6
Merge into: lp:percona-server/5.6
Diff against target: 64 lines (+38/-1)
4 files modified
mysql-test/suite/innodb/r/percona_changed_page_bmp_requests_debug.result (+9/-0)
mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug-master.opt (+1/-0)
mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug.test (+27/-0)
storage/innobase/log/log0online.cc (+1/-1)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1382336-5.6
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+238658@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'mysql-test/suite/innodb/r/percona_changed_page_bmp_requests_debug.result'
2--- mysql-test/suite/innodb/r/percona_changed_page_bmp_requests_debug.result 1970-01-01 00:00:00 +0000
3+++ mysql-test/suite/innodb/r/percona_changed_page_bmp_requests_debug.result 2014-10-17 06:11:15 +0000
4@@ -0,0 +1,9 @@
5+CREATE TABLE t1(a INT) ENGINE=InnoDB;
6+INSERT INTO t1 VALUES (10);
7+SET @@GLOBAL.innodb_log_checkpoint_now=TRUE;
8+SET @@GLOBAL.innodb_track_redo_log_now=TRUE;
9+PURGE CHANGED_PAGE_BITMAPS BEFORE CURRENT_LSN;
10+INSERT INTO t1 VALUES (20);
11+SET @@GLOBAL.innodb_log_checkpoint_now=TRUE;
12+SET @@GLOBAL.innodb_track_redo_log_now=TRUE;
13+DROP TABLE t1;
14
15=== added file 'mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug-master.opt'
16--- mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug-master.opt 1970-01-01 00:00:00 +0000
17+++ mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug-master.opt 2014-10-17 06:11:15 +0000
18@@ -0,0 +1,1 @@
19+--innodb_track_changed_pages=TRUE
20
21=== added file 'mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug.test'
22--- mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug.test 1970-01-01 00:00:00 +0000
23+++ mysql-test/suite/innodb/t/percona_changed_page_bmp_requests_debug.test 2014-10-17 06:11:15 +0000
24@@ -0,0 +1,27 @@
25+#
26+# Tests for changed page tracking user requests that need a debug build
27+#
28+--source include/have_innodb.inc
29+--source include/have_debug.inc
30+
31+#
32+# Bug 1382336: Purging bitmaps exactly up to the last tracked LSN aborts change tracking
33+#
34+CREATE TABLE t1(a INT) ENGINE=InnoDB;
35+
36+INSERT INTO t1 VALUES (10);
37+
38+SET @@GLOBAL.innodb_log_checkpoint_now=TRUE;
39+SET @@GLOBAL.innodb_track_redo_log_now=TRUE;
40+
41+let $current_lsn = query_get_value(SHOW STATUS LIKE 'innodb_lsn_current', Value, 1);
42+
43+--replace_regex /[0-9]+/CURRENT_LSN/
44+eval PURGE CHANGED_PAGE_BITMAPS BEFORE $current_lsn;
45+
46+INSERT INTO t1 VALUES (20);
47+
48+SET @@GLOBAL.innodb_log_checkpoint_now=TRUE;
49+SET @@GLOBAL.innodb_track_redo_log_now=TRUE;
50+
51+DROP TABLE t1;
52
53=== modified file 'storage/innobase/log/log0online.cc'
54--- storage/innobase/log/log0online.cc 2014-08-22 13:31:49 +0000
55+++ storage/innobase/log/log0online.cc 2014-10-17 06:11:15 +0000
56@@ -1808,7 +1808,7 @@
57 return TRUE;
58 }
59
60- if (srv_track_changed_pages && lsn >= log_bmp_sys->end_lsn) {
61+ if (srv_track_changed_pages && lsn > log_bmp_sys->end_lsn) {
62 /* If we have to delete the current output file, close it
63 first. */
64 os_file_close(log_bmp_sys->out.file);

Subscribers

People subscribed via source and target branches