Merge lp:~laurynas-biveinis/percona-server/bug1286114-5.5 into lp:percona-server/5.5

[Laurynas Biveinis]

    Fix bug 1286114 (Slow file extend when innodb_use_fallocate=1 and SSD
    file storage) based on the patch by Jan Lindström.

    Replace the posix_fallocate zero to desired extent-calling
    os_file_set_size call in fil_extend_space_to_desired_size with a local
    posix_fallocate call that extends starting from the current end of
    file only.

http://jenkins.percona.com/job/percona-server-5.5-param/966/
Also run MTR locally with enabled srv_use_fallocate.

[Sergei Glushchenko (sergei.glushchenko)]

Approve

review: Approve (g2)

=== modified file 'storage/innobase/fil/fil0fil.c'
--- storage/innobase/fil/fil0fil.c	2013-12-05 08:07:26 +0000
+++ storage/innobase/fil/fil0fil.c	2014-03-06 09:27:53 +0000
@@ -4953,14 +4953,24 @@
 
 #ifdef HAVE_POSIX_FALLOCATE
 	if (srv_use_posix_fallocate) {
-		offset_high = (size_after_extend - file_start_page_no)
-			* page_size / (4ULL * 1024 * 1024 * 1024);
-		offset_low = (size_after_extend - file_start_page_no)
-			* page_size % (4ULL * 1024 * 1024 * 1024);
+
+		ib_int64_t	start_offset
+			= file_start_page_no * page_size;
+		ib_int64_t	end_offset
+			= (size_after_extend - file_start_page_no) * page_size;
 
 		mutex_exit(&fil_system->mutex);
-		success = os_file_set_size(node->name, node->handle,
-					   offset_low, offset_high);
+		success = (posix_fallocate(node->handle, start_offset,
+					   end_offset) == 0);
+		if (!success)
+		{
+			fprintf(stderr,
+				"InnoDB: Error: preallocating file space for "
+				"file \'%s\' failed.  Current size %lld, "
+				"len %lld, desired size %lld\n", node->name,
+				start_offset, end_offset,
+				start_offset + end_offset);
+		}
 		mutex_enter(&fil_system->mutex);
 		if (success) {
 			node->size += (size_after_extend - start_page_no);