Merge lp:~laurynas-biveinis/percona-server/bug1272747 into lp:percona-server/5.6

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 536
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1272747
Merge into: lp:percona-server/5.6
Diff against target: 40 lines (+18/-1)
2 files modified
storage/innobase/include/sync0sync.h (+1/-1)
storage/innobase/include/sync0sync.ic (+17/-0)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1272747
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+203318@code.launchpad.net

Description of the change

Fix bug 1272747 (5.6 link failure with WITH_PFS=0) by providing the
missing mutex_enter_nowait_func(ib_prio_mutex_t*, const char*, ulint)
definition.

http://jenkins.percona.com/job/percona-server-5.6-param/491/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storage/innobase/include/sync0sync.h'
2--- storage/innobase/include/sync0sync.h 2013-12-05 17:23:10 +0000
3+++ storage/innobase/include/sync0sync.h 2014-01-27 13:23:45 +0000
4@@ -358,7 +358,7 @@
5 directly. Tries to lock the mutex for the current thread. If the lock is not
6 acquired immediately, returns with return value 1.
7 @return 0 if succeed, 1 if not */
8-UNIV_INTERN
9+UNIV_INLINE
10 ulint
11 mutex_enter_nowait_func(
12 /*====================*/
13
14=== modified file 'storage/innobase/include/sync0sync.ic'
15--- storage/innobase/include/sync0sync.ic 2013-10-23 08:48:28 +0000
16+++ storage/innobase/include/sync0sync.ic 2014-01-27 13:23:45 +0000
17@@ -316,6 +316,23 @@
18 mutex_spin_wait(mutex, high_priority, file_name, line);
19 }
20
21+/********************************************************************//**
22+NOTE! Use the corresponding macro in the header file, not this function
23+directly. Tries to lock the mutex for the current thread. If the lock is not
24+acquired immediately, returns with return value 1.
25+@return 0 if succeed, 1 if not */
26+UNIV_INLINE
27+ulint
28+mutex_enter_nowait_func(
29+/*====================*/
30+ ib_prio_mutex_t* mutex, /*!< in: pointer to mutex */
31+ const char* file_name, /*!< in: file name where mutex
32+ requested */
33+ ulint line) /*!< in: line where
34+ requested */
35+{
36+ return mutex_enter_nowait_func(&mutex->base_mutex, file_name, line);
37+}
38
39 #ifdef UNIV_PFS_MUTEX
40 /******************************************************************//**

Subscribers

People subscribed via source and target branches