Percona Server moved to https://jira.percona.com/projects/PS

lp:~laurynas-biveinis/percona-server/bug1217002-5.1

Created by Laurynas Biveinis on 2013-09-05 and last modified on 2013-09-09

Get this branch:: bzr branch lp:~laurynas-biveinis/percona-server/bug1217002-5.1

Only Laurynas Biveinis can upload to this branch. If you are Laurynas Biveinis please log in for upload directions.

Branch merges

Merged into lp:percona-server/5.1 at revision 590

Alexey Kopytov (community): Approve on 2013-09-24

Critical

Fix Released

Link a bug report

Related blueprints

Branch information

Owner:: Laurynas Biveinis

Project:: Percona Server moved to https://jira.percona.com/projects/PS

Status:: Merged

Recent revisions

578. By Laurynas Biveinis on 2013-09-09

Fix
- bug 1217002 (RENAME/DROP crashes with innodb_track_changed_pages);
- bug 1213885 (Failing assertion: error == DB_SUCCESS in file
handler0alter.cc line 4897 | abort in commit_cache_rebuild).

Both bugs are caused by a recent upstream change that makes
MLOG_FILE_RENAME to replay unconditionally whenever such log record is
parsed, which includes online log tracking.

Fix by
- asserting in fil_op_log_parse_or_replay() that, if a file operation
  is about to be executed, that recovery is on, and
- adjusting recv_parse_or_apply_log_rec_body() to only pass non-zero
  space_id to fil_op_log_parse_or_replay if recovery is on. A
  non-zero space_id is what causes fil_op_log_parse_or_replay() to
  replay and not only parse the log record.

Changes for testing:
- backport from 5.5+ the debug-only innodb_log_checkpoint_now system
  variable;
- make innodb_track_changed_pages a dynamic variable, for debug builds
  only, to provide the ability to stop log tracking temporarily;
- add a new debug-only system variable innodb_track_redo_log_now, that
  issues a synchronuous redo log parse request;
- add a new debug sync point to row_merge_rename_tables();
- use all of the above to add a testcase to
  percona_changed_page_bmp_debug test.