Merge lp:~laurynas-biveinis/percona-server/bug1151723-5.5 into lp:percona-server/5.5

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 683
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1151723-5.5
Merge into: lp:percona-server/5.5
Diff against target: 28 lines (+1/-3)
1 file modified
client/mysqlbinlog.cc (+1/-3)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1151723-5.5
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+227849@code.launchpad.net

Description of the change

Fix bug 1151723 (Remove our own fix for bug #933969) by reverting the
Percona fix but keeping the testcase.

http://jenkins.percona.com/job/percona-server-5.5-param/1028/

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'client/mysqlbinlog.cc'
2--- client/mysqlbinlog.cc 2014-02-15 00:06:35 +0000
3+++ client/mysqlbinlog.cc 2014-07-23 03:49:22 +0000
4@@ -1989,7 +1989,6 @@
5 }
6
7 pos= my_b_tell(file);
8- DBUG_ASSERT(pos == 0);
9
10 /* fstat the file to check if the file is a regular file. */
11 if (my_fstat(file->file, &my_file_stat, MYF(0)) == -1)
12@@ -2159,7 +2158,7 @@
13 /* read from normal file */
14 if ((fd = my_open(logname, O_RDONLY | O_BINARY, MYF(MY_WME))) < 0)
15 return ERROR_STOP;
16- if (init_io_cache(file, fd, 0, READ_CACHE, (my_off_t) 0, 0,
17+ if (init_io_cache(file, fd, 0, READ_CACHE, start_position_mot, 0,
18 MYF(MY_WME | MY_NABP)))
19 {
20 my_close(fd, MYF(MY_WME));
21@@ -2167,7 +2166,6 @@
22 }
23 if ((retval= check_header(file, print_event_info, logname)) != OK_CONTINUE)
24 goto end;
25- my_b_seek(file, start_position_mot);
26 }
27 else
28 {

Subscribers

People subscribed via source and target branches