Percona Server moved to https://jira.percona.com/projects/PS

lp:~laurynas-biveinis/percona-server/bug1122462

Created by Laurynas Biveinis on 2013-02-12 and last modified on 2013-02-12

Get this branch:: bzr branch lp:~laurynas-biveinis/percona-server/bug1122462

Only Laurynas Biveinis can upload to this branch. If you are Laurynas Biveinis please log in for upload directions.

Branch merges

On hold for merging into lp:percona-server/5.5

Laurynas Biveinis (community): Needs Fixing on 2013-05-16

George Ormond Lorch III: Approve (g2) on 2013-02-25

Undecided

Expired

Link a bug report

Related blueprints

Branch information

Owner:: Laurynas Biveinis

Project:: Percona Server moved to https://jira.percona.com/projects/PS

Status:: Development

Recent revisions

441. By Laurynas Biveinis on 2013-02-12

Fix bug 1122462 (InnoDB: Failing assertion: bpage->in_flush_list in
file buf0lru.c line 605).

The issue is that, even after fixing bug 934377 and friends, there is
not enough protection for the "prev" pointer in the
buf_flush_or_remove_pages() loop to start pointing to a flushed page
or become dangling due to a compressed page flush list relocation.

The fix is two part. First is acquiring the compressed page flush
mutex in buf_flush_dirty_pages() (and releasing it in
buf_flush_yield()). This ensures that the prev pointer always points
to a valid page.

The second part is to fix that, while prev cannot become dangling
anymore, it still may get removed from the flush list when the flush
list mutex is released. This is handled by replacing the assertions
at the top of the buf_flush_or_remove_pages() loop with a block state
check.

Remove some comments that do not apply for XtraDB.

440. By Laurynas Biveinis on 2013-02-12

Automerge prerequisite branch

439. By Stewart Smith on 2013-02-11

null merge 5.1 implementation of slow query log fixes, as 5.5 is sep impl

438. By <email address hidden> on 2013-02-11

Merge lp:~laurynas-biveinis/percona-server/slow-log-fixes-5.5

437. By <email address hidden> on 2013-02-09

Empty merge from Percona Server 5.1

436. By <email address hidden> on 2013-02-09

Empty merge from Percona Server 5.1

435. By <email address hidden> on 2013-02-08