Merge lp:~laurynas-biveinis/percona-server/bug1067103-5.5 into lp:percona-server/5.5

Proposed by Laurynas Biveinis on 2014-10-15
Status: Merged
Approved by: Laurynas Biveinis on 2014-10-15
Approved revision: 699
Merged at revision: 708
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1067103-5.5
Merge into: lp:percona-server/5.5
Diff against target: 12 lines (+1/-1)
1 file modified
sql/sys_vars.cc (+1/-1)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1067103-5.5
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve on 2014-10-15
Review via email: mp+238384@code.launchpad.net

Description of the change

Fix bug 1067103 (Out-of-bound reads due to incorrect definition of
log_warnings_suppress_name) by terminating the
log_warnings_suppress_name array by a NULL pointer.

Tested locally by compiling and running percona_log_warnings_suppress test.

To post a comment you must log in.
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sql/sys_vars.cc'
2--- sql/sys_vars.cc 2014-09-24 09:00:06 +0000
3+++ sql/sys_vars.cc 2014-10-15 05:02:30 +0000
4@@ -1645,7 +1645,7 @@
5 READ_ONLY GLOBAL_VAR(mysqld_port), CMD_LINE(REQUIRED_ARG, 'P'),
6 VALID_RANGE(0, UINT_MAX32), DEFAULT(0), BLOCK_SIZE(1));
7
8-const char *log_warnings_suppress_name[]= { "1592" };
9+static const char *log_warnings_suppress_name[]= { "1592", NullS };
10 static Sys_var_set Sys_log_warnings_suppress(
11 "log_warnings_suppress",
12 "disable logging of enumerated warnings: "

Subscribers

People subscribed via source and target branches