Merge lp:~laurynas-biveinis/percona-server/bug1039931 into lp:percona-server/5.1

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 478
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1039931
Merge into: lp:percona-server/5.1
Diff against target: 36 lines (+0/-19)
1 file modified
Percona-Server/storage/innodb_plugin/plug.in (+0/-19)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1039931
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+120761@code.launchpad.net

Description of the change

Issue found during 5.1 -> 5.5 bitmap writer merge:

Fix bug 1039931 (64-bit atomic operation Autoconf tests duplicated in
regular atomic operation tests).

The fix is to remove the redundant long long tests from the non-64-bit
atomic operations Autoconf tests.

For 5.5, the fix is included in the merge revision, thus this one will have to be null-merged.

Jenkins: http://jenkins.percona.com/job/percona-server-5.1-param/381/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/storage/innodb_plugin/plug.in'
2--- Percona-Server/storage/innodb_plugin/plug.in 2012-06-14 09:16:03 +0000
3+++ Percona-Server/storage/innodb_plugin/plug.in 2012-08-22 13:19:08 +0000
4@@ -67,10 +67,6 @@
5 long res;
6 char c;
7
8- long long t;
9- long long z;
10- long long res2;
11-
12 x = 10;
13 y = 123;
14 res = __sync_bool_compare_and_swap(&x, x, y);
15@@ -97,21 +93,6 @@
16 if (res != 10 || c != 123) {
17 return(1);
18 }
19-
20- t = 10;
21- z = 123;
22- res = __sync_bool_compare_and_swap(&t, t, z);
23- if (!res || t != z) {
24- return(1);
25- }
26-
27- t = 10;
28- z = 123;
29- res2 = __sync_add_and_fetch(&t, z);
30- if (res2 != 123 + 10 || t != 123 + 10) {
31- return(1);
32- }
33-
34 return(0);
35 }
36 ],

Subscribers

People subscribed via source and target branches