Merge lp:~laurynas-biveinis/percona-server/bug1036530 into lp:percona-server/5.1

[Laurynas Biveinis]

Fix bug 1036530 (Sporadic innodb_plugin.percona_changed_page_bmp
failures in Jenkins).

The problem was flawed and unfinished crash injection testing in the
test case: the last server restart set up a crash injection before the
bitmap write but failed to actually trigger it in the test case. Then
the crash used to get triggered during the server shutdown bitmap
write and thus silently ignored by MTR. But sometimes the bitmap
write would happen while the server processes DROP TABLE command,
appearing as an unexpected server crash to MTR.

Fixed by triggering the crash site in the test case, waiting for the
server to come back again before starting the testsuite cleanups.

Additionally put extra workload on the server before this test case
part to have some good data pages in the bitmap file. Also added
comments to the test cace points where the LSN tracking range
contuinity will have to be tested once the necessary info is exposed
through INFORMATION_SCHEMA.

Re-recorded the testcase.

Jenkins: http://jenkins.percona.com/job/percona-server-5.1-param/368/
Issue #16274

[Stewart Smith (stewart)]

review: Approve

=== modified file 'Percona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_page_bmp.result'
--- Percona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_page_bmp.result	2012-06-14 09:16:03 +0000
+++ Percona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_page_bmp.result	2012-08-14 10:37:21 +0000
@@ -17,5 +17,8 @@
 INSERT INTO t2 VALUES (1),(2),(3),(4),(5);
 INSERT INTO t1 SELECT x FROM t1;
 SET GLOBAL INNODB_FAST_SHUTDOWN=2;
+INSERT INTO t1 VALUES (1),(2),(3),(4),(5);
 call mtr.add_suppression("InnoDB: Warning: truncated block detected.*");
+INSERT INTO t1 SELECT x FROM t1;
+ERROR HY000: Lost connection to MySQL server during query
 DROP TABLE t1, t2;

=== modified file 'Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_page_bmp.test'
--- Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_page_bmp.test	2012-06-14 09:16:03 +0000
+++ Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_page_bmp.test	2012-08-14 10:37:21 +0000
@@ -33,6 +33,9 @@
 --exec echo "restart" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
 --source include/wait_until_connected_again.inc
 
+# TODO: check the tracked LSN range continuity once this info is exposed through
+# INFORMATION_SCHEMA.
+
 # Create more log data, larger amount than the log group capacity. At the same time test second space id.
 INSERT INTO t1 SELECT x FROM t1;
 INSERT INTO t1 SELECT x FROM t1;
@@ -67,6 +70,9 @@
 
 --source include/restart_mysqld.inc
 
+# TODO: check the tracked LSN range continuity once this info is exposed through
+# INFORMATION_SCHEMA.
+
 file_exists $BITMAP_FILE;
 
 # Test that an empty existing bitmap file is handled properly when it's impossible to re-read the full missing range.
@@ -82,6 +88,8 @@
 --source include/wait_until_connected_again.inc
 
 file_exists $BITMAP_FILE;
+# Create at least one more bitmap page on shutdown
+INSERT INTO t1 VALUES (1),(2),(3),(4),(5);
 
 # Test that the bitmap file is read in block size multiples with junk at the end discarded
 --exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
@@ -97,4 +105,20 @@
 
 file_exists $BITMAP_FILE;
 
+# TODO: check the tracked LSN range continuity once this info is exposed through
+# INFORMATION_SCHEMA.
+
+# Test crashing before writing of new bitmap data
+
+--exec echo "restart" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
+--error 2013
+INSERT INTO t1 SELECT x FROM t1;
+--enable_reconnect
+--source include/wait_until_connected_again.inc
+
+file_exists $BITMAP_FILE;
+
+# TODO: check the tracked LSN range continuity once this info is exposed through
+# INFORMATION_SCHEMA.
+
 DROP TABLE t1, t2;