Percona Server moved to https://jira.percona.com/projects/PS

Merge lp:~laurynas-biveinis/percona-server/bug1032483 into lp:percona-server/5.1

  1. bug1032483
  2. Merge into 5.1
Proposed by Laurynas Biveinis
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 460
Proposed branch: lp:~laurynas-biveinis/percona-server/bug1032483
Merge into: lp:percona-server/5.1
Diff against target: 14 lines (+2/-2)
1 file modified
Percona-Server/storage/innodb_plugin/log/log0online.c (+2/-2)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug1032483
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+118042@code.launchpad.net

Description of the change

Fix bug 1032483 (log/log0online.c:338: warning: value computed is not
used).

The issue here is that unused os_atomic_* macro return values are
warned about. Fixed by casting to void.

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Approving myself, the fix is obvious and in-line with the similar fixes made earlier.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/storage/innodb_plugin/log/log0online.c'
2--- Percona-Server/storage/innodb_plugin/log/log0online.c 2012-06-14 09:16:03 +0000
3+++ Percona-Server/storage/innodb_plugin/log/log0online.c 2012-08-03 05:30:35 +0000
4@@ -335,8 +335,8 @@
5 /* Single writer, no data race here */
6 ib_uint64_t old_value
7 = os_atomic_increment_uint64(&log_sys->tracked_lsn, 0);
8- os_atomic_increment_uint64(&log_sys->tracked_lsn,
9- tracked_lsn - old_value);
10+ (void) os_atomic_increment_uint64(&log_sys->tracked_lsn,
11+ tracked_lsn - old_value);
12 #else
13 mutex_enter(&log_sys->mutex);
14 log_sys->tracked_lsn = tracked_lsn;

Subscribers

People subscribed via source and target branches