Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1083596-5.5 into lp:percona-server/5.5

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 414
Proposed branch: lp:~laurynas-biveinis/percona-server/BT-16274-bug1083596-5.5
Merge into: lp:percona-server/5.5
Prerequisite: lp:~laurynas-biveinis/percona-server/BT-16274-bug1082437-5.5
Diff against target: 83 lines (+42/-2)
4 files modified
Percona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp.result (+7/-0)
Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp.test (+26/-0)
Percona-Server/storage/innobase/log/log0online.c (+4/-2)
Percona-Server/storage/innobase/srv/srv0start.c (+5/-0)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1083596-5.5
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Review via email: mp+136612@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) :
review: Approve
Revision history for this message
Stewart Smith (stewart) wrote :

http://jenkins.percona.com/view/Merge/job/merge-PS-5.5-staging/27/BUILD_TYPE=release,Host=ubuntu-lucid-32bit/testReport/junit/%28root%29/innodb/percona_changed_page_bmp_2/

Logfile:
CURRENT_TEST: innodb.percona_changed_page_bmp
mysqltest: At line 221: query 'RESET ALL CHANGED PAGE BITMAPS' failed: 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ALL CHANGED PAGE BITMAPS' at line 1

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp.result'
2--- Percona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp.result 2013-01-31 11:52:07 +0000
3+++ Percona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp.result 2013-02-04 11:31:24 +0000
4@@ -44,4 +44,11 @@
5 ib_modified_log_1
6 ib_modified_log_2
7 7th restart
8+ib_modified_log_1
9+ib_modified_log_2
10+ib_modified_log_3
11+8th restart
12+RESET CHANGED_PAGE_BITMAPS;
13+call mtr.add_suppression("InnoDB: Error: page [0-9]* log sequence number [0-9]*");
14+9th restart
15 DROP TABLE t1, t2;
16
17=== modified file 'Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp.test'
18--- Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp.test 2013-01-31 11:52:07 +0000
19+++ Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp.test 2013-02-04 11:31:24 +0000
20@@ -198,4 +198,30 @@
21 --exec echo "restart" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
22 --source include/wait_until_connected_again.inc
23
24+# TODO: check the tracked LSN range continuity once this info is exposed through
25+# INFORMATION_SCHEMA.
26+
27+file_exists $BITMAP_FILE;
28+--replace_regex /_[[:digit:]]+\.xdb$//
29+list_files $MYSQLD_DATADIR ib_modified_log*;
30+
31+#
32+# Test for log tracking compatibility with innodb_force_recovery (bug 1083596).
33+#
34+
35+--exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
36+--shutdown_server 10
37+--source include/wait_until_disconnected.inc
38+--enable_reconnect
39+--echo 8th restart
40+--exec echo "restart:--innodb-force-recovery=6" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
41+--source include/wait_until_connected_again.inc
42+
43+# innodb_force_recovery desyncs bitmap data and logs
44+RESET CHANGED_PAGE_BITMAPS;
45+
46+call mtr.add_suppression("InnoDB: Error: page [0-9]* log sequence number [0-9]*");
47+--echo 9th restart
48+--source include/restart_mysqld.inc
49+
50 DROP TABLE t1, t2;
51
52=== modified file 'Percona-Server/storage/innobase/log/log0online.c'
53--- Percona-Server/storage/innobase/log/log0online.c 2013-01-22 16:32:44 +0000
54+++ Percona-Server/storage/innobase/log/log0online.c 2013-02-04 11:31:24 +0000
55@@ -413,8 +413,10 @@
56
57 if (last_tracked_lsn > tracking_start_lsn) {
58 fprintf(stderr,
59- "InnoDB: Error: last tracked LSN is in future. This "
60- "can be caused by mismatched bitmap files.\n");
61+ "InnoDB: Error: last tracked LSN %llu is ahead of "
62+ "tracking start LSN %llu. This can be caused by "
63+ "mismatched bitmap files.\n", last_tracked_lsn,
64+ tracking_start_lsn);
65 exit(1);
66 }
67
68
69=== modified file 'Percona-Server/storage/innobase/srv/srv0start.c'
70--- Percona-Server/storage/innobase/srv/srv0start.c 2012-11-25 09:30:58 +0000
71+++ Percona-Server/storage/innobase/srv/srv0start.c 2013-02-04 11:31:24 +0000
72@@ -1155,6 +1155,11 @@
73 init_log_online(void)
74 /*=================*/
75 {
76+ if (UNIV_UNLIKELY(srv_force_recovery > 0)) {
77+ srv_track_changed_pages = FALSE;
78+ return;
79+ }
80+
81 if (srv_track_changed_pages) {
82
83 log_online_read_init();

Subscribers

People subscribed via source and target branches