Merge lp:~larsu/unity/add-indicator-printers-support into lp:unity

Proposed by Lars Karlitski
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 2014
Proposed branch: lp:~larsu/unity/add-indicator-printers-support
Merge into: lp:unity
Diff against target: 24 lines (+2/-1)
2 files modified
com.canonical.Unity.gschema.xml (+1/-1)
services/panel-service.c (+1/-0)
To merge this branch: bzr merge lp:~larsu/unity/add-indicator-printers-support
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Review via email: mp+94172@code.launchpad.net

Description of the change

= Problem description =

In precise, print status is shown via an indicator instead of using system-config-printer's applet (which is whitelisted in Unity right now).

= The fix =

This patch makes sure the print indicator is shown at the correct position in the panel and removes the whitelist entry for 'scp-dbus-service'.

= Test coverage =

None, trivial change.

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'com.canonical.Unity.gschema.xml'
2--- com.canonical.Unity.gschema.xml 2012-02-07 15:41:42 +0000
3+++ com.canonical.Unity.gschema.xml 2012-02-22 14:26:43 +0000
4@@ -40,7 +40,7 @@
5 </schema>
6 <schema path="/desktop/unity/panel/" id="com.canonical.Unity.Panel" gettext-domain="unity">
7 <key type="as" name="systray-whitelist">
8- <default>[ 'JavaEmbeddedFrame', 'Wine', 'scp-dbus-service', 'Update-notifier' ]</default>
9+ <default>[ 'JavaEmbeddedFrame', 'Wine', 'Update-notifier' ]</default>
10 <summary>List of client names, resource classes or wm classes to allow in the Panel's systray implementation.</summary>
11 <description>"" (empty) will not allow any tray icons, "all" will allow all tray icons, otherwise there will be an attempt to match each icon to a value here.</description>
12 </key>
13
14=== modified file 'services/panel-service.c'
15--- services/panel-service.c 2012-02-04 05:28:23 +0000
16+++ services/panel-service.c 2012-02-22 14:26:43 +0000
17@@ -99,6 +99,7 @@
18 static const gchar * indicator_order[][2] = {
19 {"libappmenu.so", NULL}, /* indicator-appmenu" */
20 {"libapplication.so", NULL}, /* indicator-application" */
21+ {"libprintersmenu.so", NULL}, /* indicator-printers */
22 {"libapplication.so", "gsd-keyboard-xkb"}, /* keyboard layout selector */
23 {"libmessaging.so", NULL}, /* indicator-messages */
24 {"libpower.so", NULL}, /* indicator-power */