Ubuntu theme

Merge lp:~larsu/ubuntu-themes/webkit-scrollbar into lp:ubuntu-themes

  1. webkit-scrollbar
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Merged
Approved by: Iain Lane
Approved revision: 464
Merged at revision: 464
Proposed branch: lp:~larsu/ubuntu-themes/webkit-scrollbar
Merge into: lp:ubuntu-themes
Diff against target: 43 lines (+10/-0)
2 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+5/-0)
Radiance/gtk-3.0/gtk-widgets.css (+5/-0)
To merge this branch: bzr merge lp:~larsu/ubuntu-themes/webkit-scrollbar
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Iain Lane Approve
Review via email: mp+283282@code.launchpad.net

Commit message

Scrollbars: fix through drawing on webkit

Description of the change

Scrollbars: fix through drawing on webkit

Webkit pulls colors out of gtk's theme, but doesn't handle transparency well. It doesn't set the overlay-indicator class, which is meant for overlay scrollbars. Only set the background transparent when that class is set.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks Lars!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:464
http://jenkins.qa.ubuntu.com/job/ubuntu-themes-ci/126/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-vivid-amd64-ci/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-vivid-armhf-ci/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-vivid-i386-ci/40

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-themes-ci/126/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
2--- Ambiance/gtk-3.0/gtk-widgets.css 2015-12-16 15:29:02 +0000
3+++ Ambiance/gtk-3.0/gtk-widgets.css 2016-01-20 12:08:00 +0000
4@@ -1151,12 +1151,17 @@
5 -GtkScrollbar-min-slider-length: 31;
6 -GtkRange-slider-width: 10;
7
8+ background-color: @scrollbar_track_color;
9 background-image: none;
10 background-size: 0;
11 border: none;
12 border-radius: 0;
13 }
14
15+.scrollbar.overlay-indicator {
16+ background-color: transparent;
17+}
18+
19 .scrollbar:hover,
20 .scrollbar.dragging {
21 background-color: @scrollbar_track_color;
22
23=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
24--- Radiance/gtk-3.0/gtk-widgets.css 2015-12-16 15:29:02 +0000
25+++ Radiance/gtk-3.0/gtk-widgets.css 2016-01-20 12:08:00 +0000
26@@ -1173,12 +1173,17 @@
27 -GtkScrollbar-min-slider-length: 31;
28 -GtkRange-slider-width: 10;
29
30+ background-color: @scrollbar_track_color;
31 background-image: none;
32 background-size: 0;
33 border: none;
34 border-radius: 0;
35 }
36
37+.scrollbar.overlay-indicator {
38+ background-color: transparent;
39+}
40+
41 .scrollbar:hover,
42 .scrollbar.dragging {
43 background-color: @scrollbar_track_color;

Subscribers

People subscribed via source and target branches