Ubuntu theme

Merge lp:~larsu/ubuntu-themes/progress-bars into lp:ubuntu-themes

  1. progress-bars
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Rejected
Rejected by: Iain Lane
Proposed branch: lp:~larsu/ubuntu-themes/progress-bars
Merge into: lp:ubuntu-themes
Diff against target: 33 lines (+4/-2)
3 files modified
.bzr-builddeb/default.conf (+0/-2)
Ambiance/gtk-3.0/gtk-widgets.css (+2/-0)
Radiance/gtk-3.0/gtk-widgets.css (+2/-0)
To merge this branch: bzr merge lp:~larsu/ubuntu-themes/progress-bars
Reviewer Review Type Date Requested Status
Iain Lane Needs Information
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+254544@code.launchpad.net

Commit message

Reduce spacing between progress bars and labels

This is necessary because gtk honors the style properties of progress bars again.

 https://bugzilla.gnome.org/show_bug.cgi?id=746688

Description of the change

Reduce spacing between progress bars and labels

This is necessary because gtk honors the style properties of progress bars again.

 https://bugzilla.gnome.org/show_bug.cgi?id=746688

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:424
http://jenkins.qa.ubuntu.com/job/ubuntu-themes-ci/96/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-vivid-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-vivid-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-themes-ci/96/rebuild

review: Approve (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Why do you remove the default.conf?

& is this still necessary (for safety?) given that the committed version in gtk changed the default to 2 anyway?

review: Needs Information
Revision history for this message
Lars Karlitski (larsu) wrote :

> Why do you remove the default.conf?

By accident.

> & is this still necessary (for safety?) given that the committed version in
> gtk changed the default to 2 anyway?

Yeah... Let's just abandon this as the default is unlikely to change again in the near future.

Unmerged revisions

424. By Lars Karlitski

Reduce spacing between progress bars and labels

This is necessary because gtk honors the style properties of progress
bars again.

https://bugzilla.gnome.org/show_bug.cgi?id=746688

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed directory '.bzr-builddeb'
2=== removed file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 2012-12-10 14:29:46 +0000
4+++ .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
5@@ -1,2 +0,0 @@
6-[BUILDDEB]
7-split = True
8
9=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
10--- Ambiance/gtk-3.0/gtk-widgets.css 2015-03-20 15:43:13 +0000
11+++ Ambiance/gtk-3.0/gtk-widgets.css 2015-03-30 08:52:02 +0000
12@@ -21,6 +21,8 @@
13 -GtkPaned-handle-size: 6;
14 -GtkProgressBar-min-horizontal-bar-height: 14;
15 -GtkProgressBar-min-vertical-bar-width: 14;
16+ -GtkProgressBar-xspacing: 2;
17+ -GtkProgressBar-yspacing: 2;
18 -GtkRange-trough-border: 0;
19 -GtkRange-slider-width: 14;
20 -GtkRange-stepper-size: 13;
21
22=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
23--- Radiance/gtk-3.0/gtk-widgets.css 2015-03-20 15:43:13 +0000
24+++ Radiance/gtk-3.0/gtk-widgets.css 2015-03-30 08:52:02 +0000
25@@ -21,6 +21,8 @@
26 -GtkPaned-handle-size: 6;
27 -GtkProgressBar-min-horizontal-bar-height: 14;
28 -GtkProgressBar-min-vertical-bar-width: 14;
29+ -GtkProgressBar-xspacing: 2;
30+ -GtkProgressBar-yspacing: 2;
31 -GtkRange-trough-border: 0;
32 -GtkRange-slider-width: 14;
33 -GtkRange-stepper-size: 13;

Subscribers

People subscribed via source and target branches