Merge lp:~larsu/ubuntu-themes/evolution-fixes into lp:ubuntu-themes

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 401
Merged at revision: 402
Proposed branch: lp:~larsu/ubuntu-themes/evolution-fixes
Merge into: lp:ubuntu-themes
Diff against target: 133 lines (+58/-14)
6 files modified
Ambiance/gtk-3.0/gtk-main.css (+1/-0)
Ambiance/gtk-3.0/gtk-widgets.css (+5/-7)
Ambiance/gtk-3.0/public-colors.css (+23/-0)
Radiance/gtk-3.0/gtk-main.css (+1/-0)
Radiance/gtk-3.0/gtk-widgets.css (+5/-7)
Radiance/gtk-3.0/public-colors.css (+23/-0)
To merge this branch: bzr merge lp:~larsu/ubuntu-themes/evolution-fixes
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+238174@code.launchpad.net

Commit message

Gtk theme: expose public colors with Adwaita's naming scheme

Some applications depend on those colors being defined, even though it is bad form to do so. Expose them until applications get fixed.

This commit adds those colors as aliases for internal colors. Renaming all occurences would mess with history too much.

Also add background hack for evolution's mail preferences dialog

Description of the change

Gtk theme: expose public colors with Adwaita's naming scheme

Some applications depend on those colors being defined, even though it is bad form to do so. Expose them until applications get fixed.

This commit adds those colors as aliases for internal colors. Renaming all occurences would mess with history too much.

Also add background hack for evolution's mail preferences dialog

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

looks fine to me, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/gtk-main.css'
2--- Ambiance/gtk-3.0/gtk-main.css 2014-09-09 10:51:25 +0000
3+++ Ambiance/gtk-3.0/gtk-main.css 2014-10-13 15:05:31 +0000
4@@ -50,3 +50,4 @@
5 @import url("apps/unity-greeter.css");
6 @import url("apps/glade.css");
7 @import url("apps/california.css");
8+@import url("public-colors.css");
9
10=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
11--- Ambiance/gtk-3.0/gtk-widgets.css 2014-09-12 15:16:26 +0000
12+++ Ambiance/gtk-3.0/gtk-widgets.css 2014-10-13 15:05:31 +0000
13@@ -91,6 +91,11 @@
14 background-color: @bg_color;
15 }
16
17+/* ... and for Evolution's mail preferences window */
18+EPreferencesWindow GtkNotebook GtkAlignment GtkVBox {
19+ background-color: @bg_color;
20+}
21+
22 /*********
23 * arrow *
24 *********/
25@@ -668,13 +673,6 @@
26 padding: 5px 7px;
27
28 color: @text_color;
29-
30- /* Evolution sets the background color of its mail window to the background
31- * color of entries, but cannot handle background images. Setting the
32- * background color here doesn't effect real entries, because
33- * 'background-image' has precedence.
34- */
35- background-color: @base_color;
36 }
37
38 GtkComboBox.combobox-entry .button:backdrop,
39
40=== added file 'Ambiance/gtk-3.0/public-colors.css'
41--- Ambiance/gtk-3.0/public-colors.css 1970-01-01 00:00:00 +0000
42+++ Ambiance/gtk-3.0/public-colors.css 2014-10-13 15:05:31 +0000
43@@ -0,0 +1,23 @@
44+/*
45+ * Some applications depend on these named colors.
46+ */
47+
48+@define-color theme_fg_color @fg_color;
49+@define-color theme_bg_color @bg_color;
50+@define-color theme_base_color @base_color;
51+@define-color theme_selected_bg_color @selected_bg_color;
52+@define-color theme_selected_fg_color @selected_fg_color;
53+@define-color insensitive_bg_color @bg_color;
54+@define-color insensitive_fg_color @fg_color;
55+@define-color insensitive_base_color @base_color;
56+@define-color theme_unfocused_fg_color @backdrop_fg_color;
57+@define-color theme_unfocused_bg_color @bg_color;
58+@define-color theme_unfocused_base_color @base_color;
59+@define-color theme_unfocused_selected_bg_color @selected_bg_color;
60+@define-color theme_unfocused_selected_fg_color @selected_fg_color;
61+@define-color borders shade(@bg_color, 0.82);
62+@define-color unfocused_borders transparent;
63+
64+@define-color warning_color @warning_fg_color;
65+@define-color error_color @error_fg_color;
66+@define-color success_color @success_color;
67
68=== modified file 'Radiance/gtk-3.0/gtk-main.css'
69--- Radiance/gtk-3.0/gtk-main.css 2014-09-09 10:51:25 +0000
70+++ Radiance/gtk-3.0/gtk-main.css 2014-10-13 15:05:31 +0000
71@@ -51,3 +51,4 @@
72 @import url("apps/gnome-system-log.css");
73 @import url("apps/glade.css");
74 @import url("apps/california.css");
75+@import url("public-colors.css");
76
77=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
78--- Radiance/gtk-3.0/gtk-widgets.css 2014-09-12 15:16:26 +0000
79+++ Radiance/gtk-3.0/gtk-widgets.css 2014-10-13 15:05:31 +0000
80@@ -90,6 +90,11 @@
81 background-color: @bg_color;
82 }
83
84+/* ... and for Evolution's mail preferences window */
85+EPreferencesWindow GtkNotebook GtkAlignment GtkVBox {
86+ background-color: @bg_color;
87+}
88+
89 /*********
90 * arrow *
91 *********/
92@@ -672,13 +677,6 @@
93 padding: 5px 7px;
94
95 color: @text_color;
96-
97- /* Evolution sets the background color of its mail window to the background
98- * color of entries, but cannot handle background images. Setting the
99- * background color here doesn't effect real entries, because
100- * 'background-image' has precedence.
101- */
102- background-color: @base_color;
103 }
104
105 GtkComboBox.combobox-entry .button:backdrop,
106
107=== added file 'Radiance/gtk-3.0/public-colors.css'
108--- Radiance/gtk-3.0/public-colors.css 1970-01-01 00:00:00 +0000
109+++ Radiance/gtk-3.0/public-colors.css 2014-10-13 15:05:31 +0000
110@@ -0,0 +1,23 @@
111+/*
112+ * Some applications depend on these named colors.
113+ */
114+
115+@define-color theme_fg_color @fg_color;
116+@define-color theme_bg_color @bg_color;
117+@define-color theme_base_color @base_color;
118+@define-color theme_selected_bg_color @selected_bg_color;
119+@define-color theme_selected_fg_color @selected_fg_color;
120+@define-color insensitive_bg_color @bg_color;
121+@define-color insensitive_fg_color @fg_color;
122+@define-color insensitive_base_color @base_color;
123+@define-color theme_unfocused_fg_color @backdrop_fg_color;
124+@define-color theme_unfocused_bg_color @bg_color;
125+@define-color theme_unfocused_base_color @base_color;
126+@define-color theme_unfocused_selected_bg_color @selected_bg_color;
127+@define-color theme_unfocused_selected_fg_color @selected_fg_color;
128+@define-color borders shade(@bg_color, 0.82);
129+@define-color unfocused_borders transparent;
130+
131+@define-color warning_color @warning_fg_color;
132+@define-color error_color @error_fg_color;
133+@define-color success_color @success_color;

Subscribers

People subscribed via source and target branches