Ubuntu theme

Merge lp:~larsu/ubuntu-themes/add-menu-margin into lp:ubuntu-themes

  1. add-menu-margin
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 352
Merged at revision: 352
Proposed branch: lp:~larsu/ubuntu-themes/add-menu-margin
Merge into: lp:ubuntu-themes
Diff against target: 25 lines (+4/-0)
2 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+2/-0)
Radiance/gtk-3.0/gtk-widgets.css (+2/-0)
To merge this branch: bzr merge lp:~larsu/ubuntu-themes/add-menu-margin
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sebastien Bacher Approve
Review via email: mp+209632@code.launchpad.net

Commit message

Add margin to popup menus to prevent accidental clicks

Gtk displaces the menus based on the margin. A margin of 1px ensures that the mouse pointer is not over the first (or last) menu item after right-clicking.

Description of the change

Add margin to popup menus to prevent accidental clicks

Gtk displaces the menus based on the margin. A margin of 1px ensures that the mouse pointer is not over the first (or last) menu item after right-clicking.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

tested with the new gtk, works as it should!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:352
http://jenkins.qa.ubuntu.com/job/ubuntu-themes-ci/48/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-trusty-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-trusty-armhf-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-themes-trusty-i386-ci/28

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-themes-ci/48/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
2--- Ambiance/gtk-3.0/gtk-widgets.css 2014-03-04 17:27:22 +0000
3+++ Ambiance/gtk-3.0/gtk-widgets.css 2014-03-06 10:31:49 +0000
4@@ -913,6 +913,8 @@
5 inset 0 -1px shade (@dark_bg_color, 1.18),
6 inset -1px 0 shade (@dark_bg_color, 1.16),
7 inset 1px 0 shade (@dark_bg_color, 1.18);
8+
9+ margin: 1px;
10 }
11
12 .toolbar .menu,
13
14=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
15--- Radiance/gtk-3.0/gtk-widgets.css 2014-03-04 17:27:22 +0000
16+++ Radiance/gtk-3.0/gtk-widgets.css 2014-03-06 10:31:49 +0000
17@@ -915,6 +915,8 @@
18 inset 0 -1px shade (@dark_bg_color, 1.18),
19 inset -1px 0 shade (@dark_bg_color, 1.16),
20 inset 1px 0 shade (@dark_bg_color, 1.18);
21+
22+ margin: 1px;
23 }
24
25 .toolbar .menu,

Subscribers

People subscribed via source and target branches