Merge lp:~larsu/telepathy-indicator/fix-warnings into lp:telepathy-indicator
Proposed by
Lars Karlitski
Status: | Merged |
---|---|
Approved by: | Charles Kerr |
Approved revision: | 75 |
Merged at revision: | 75 |
Proposed branch: | lp:~larsu/telepathy-indicator/fix-warnings |
Merge into: | lp:telepathy-indicator |
Diff against target: |
391 lines (+115/-83) 1 file modified
src/indicator-approver.c (+115/-83) |
To merge this branch: | bzr merge lp:~larsu/telepathy-indicator/fix-warnings |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Listen to telepathy events even when empathy is not running
Description of the change
Listen to telepathy events even when empathy is not running
Clearing the approver and observer objects doesn't seem to disconnect all callbacks from telepathy. This patch keeps both alive and does nothing when empathy is not running.
This gets rid of a lot of warnings.
To post a comment you must log in.
PASSED: Continuous integration, rev:75 jenkins. qa.ubuntu. com/job/ telepathy- indicator- ci/2/ jenkins. qa.ubuntu. com/job/ telepathy- indicator- trusty- amd64-ci/ 1 jenkins. qa.ubuntu. com/job/ telepathy- indicator- trusty- armhf-ci/ 1 jenkins. qa.ubuntu. com/job/ telepathy- indicator- trusty- armhf-ci/ 1/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/telepathy- indicator- ci/2/rebuild
http://