Code review comment for lp:~larsu/rhythmbox/add-traditional-menubar

> Looks mostly good, some small issues:
>
> - repeat/shuffle are displayed unactive

This was a problem with the actions themselves. They had an unnecessary boolean parameter. I've added a patch that fixes them. It's a separate patch because it has better chances at getting accepted upstream than the menubar one (which I still hope to get in).

> - there is an empty "tools" menu (not a new issue iirc)

Fixed by moving the "Plugins" menu item from Edit to Tools as suggested by Matthew.

> - the volume actions don't seem to do anything visible?

As discussed on IRC, they do change the apps volume but are pretty useless. We decided to leave them in though.