lp:~larsu/notify-osd/fix-1189281

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:notify-osd at revision 466

PS Jenkins bot (community): Approve (continuous-integration) on 2013-06-11

Mirco Müller (community): Approve on 2013-06-11

Sebastien Bacher: Pending requested 2013-06-10

Diff: 74 lines (+12/-6)

2 files modified

src/display.c (+6/-3)
src/stack.c (+6/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1189281: notify-osd sefaults in bubble_get_id() trying to access an unrefed object

High

Fix Released

Link a bug report

Related blueprints

466. By Lars Karlitski on 2013-06-10

Don't crash when an application is fullscreen when a notification arrives

465. By PS Jenkins bot on 2013-05-30

Releasing 0.9.35daily13.05.30-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

464. By PS Jenkins bot on 2013-05-29

Releasing 0.9.35daily13.05.29ubuntu.unity.next-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

463. By PS Jenkins bot on 2013-05-20

Releasing 0.9.35daily13.05.20ubuntu.unity.next-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

462. By Łukasz Zemczak on 2013-05-02

Modifications related to compliance with our packaging standards.

Approved by PS Jenkins bot, Ken VanDine.

461. By PS Jenkins bot on 2012-11-28

Releasing 0.9.35daily12.11.28-0ubuntu1 to ubuntu.

Approved by .

460. By Didier Roche-Tolomelli on 2012-11-27

add boostrap message.

Approved by .

459. By Robert Bruce Park on 2012-11-27

This branch is based off lp:~robru/notify-osd/inline-packaging, with the following differences:
* raring->UNRELEASED
* Use ./autogen.sh during autoreconf
* Doesn't try to run tests during build, but instead as a dep8 test (needs its schema to be installed in system)
* I disabled a test that required the user to click a button in a dialog. The test suite should be automatic.

Approved by Didier Roche.

458. By Andrea Cimitan on 2012-11-26

Add some color tweak capabilities, and slightly start tweaking colors. Fixes: https://bugs.launchpad.net/bugs/977974.

Approved by jenkins, John Lea.

457. By Michael Terry on 2012-11-26

When running without a compositor, there is an ugly black border.

This branch fixes that by:
1) Adding an 'is_composited' argument to defaults_get_bubble_shadow_size and defaults_get_bubble_corner_radius. If we're not composited, they return 0.0f.
2) Adding a 'GdkScreen **screen' argument to defaults_get_top_corner
3) Using these throughout to check composited state wherever these are used.

Additionally, I had to add some oddness in bubble.c for _refresh_background. There is a bit of code that draws a (seemingly unnecessary) image in shadow-size-units even in the uncomposited case. But it can't use 0 because that causes a crash to create a 0-sized image. So I used 1 for that special case. Seems like it would be cleaner to avoid that path in uncomposited mode, but I didn't feel confident enough to make that change.

Approved by Didier Roche, jenkins.