Merge lp:~larsu/notify-osd/allow-being-replaced into lp:notify-osd

[Lars Karlitski]

Allow being replaced by a different notification service

Allow being replaced by a different notification service

[Lars Karlitski (larsu)]

Mirco, it would be cool if the service would exit when it lost the name. Do you mind adding that on top of this branch?

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:472
http://jenkins.qa.ubuntu.com/job/notify-osd-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-trusty-armhf-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-trusty-i386-ci/3

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notify-osd-ci/7/rebuild

review: Approve (continuous-integration)

[Mirco Müller (macslow)]

As far as I understand DBus (and the "RequestName" method with its corresponding flags) I need to change our new notification-backend (lp:unity-notifications) to set DBUS_NAME_FLAG_REPLACE_EXISTING when requesting to take over the notification-service.

Just digging through Qt's QDBusConnection-docs to see how that would work. I'll be putting up a branch for it (and linking it here too) once I have that working and tested with your notify-osd branch.

[Mirco Müller (macslow)]

Just now chatted with Saviq and also saw you already have the needed branch for unity-notifications. I'm now looking into notify-osd cleanly exiting once unity8 took over the notification-service.

[Mirco Müller (macslow)]

See https://code.launchpad.net/~macslow/notify-osd/exit-if-being-replaced/+merge/193121 which builds upon your branch and completes the implementation of the needed feature.

[Mirco Müller (macslow)]

review: Approve

=== modified file 'src/dbus.c'
--- src/dbus.c	2009-08-26 11:17:55 +0000
+++ src/dbus.c	2013-10-29 01:30:40 +0000
@@ -74,7 +74,7 @@
 				"RequestName",
 				&error,
 				G_TYPE_STRING, service_name,
-				G_TYPE_UINT, 0,
+				G_TYPE_UINT, DBUS_NAME_FLAG_ALLOW_REPLACEMENT,
 				G_TYPE_INVALID,
 				G_TYPE_UINT, &request_name_result,
 				G_TYPE_INVALID))