libindicator

Merge lp:~larsu/libindicator/fix-failing into lp:libindicator/13.10

  1. fix-failing
  2. Merge into trunk.13.10
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 496
Merged at revision: 497
Proposed branch: lp:~larsu/libindicator/fix-failing
Merge into: lp:libindicator/13.10
Prerequisite: lp:~ted/libindicator/no-gtk2-tools
Diff against target: 11 lines (+1/-1)
1 file modified
libindicator/indicator-ng.c (+1/-1)
To merge this branch: bzr merge lp:~larsu/libindicator/fix-failing
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Charles Kerr Pending
Review via email: mp+168176@code.launchpad.net

This proposal supersedes a proposal from 2013-06-07.

Commit message

indicator-ng: properly fail when keyfile doesn't exist

Description of the change

indicator-ng: properly fail when keyfile doesn't exist

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote : Posted in a previous version of this proposal

Nice work! Hard to believe that was passing before.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/libindicator-autolanding/9/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-autolanding/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-autolanding/7/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:496
http://jenkins.qa.ubuntu.com/job/libindicator-ci/27/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/13/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/27/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libindicator/indicator-ng.c'
2--- libindicator/indicator-ng.c 2013-05-29 18:54:35 +0000
3+++ libindicator/indicator-ng.c 2013-06-07 20:38:23 +0000
4@@ -496,7 +496,7 @@
5 {
6 IndicatorNg *self = INDICATOR_NG (initable);
7 GKeyFile *keyfile;
8- gboolean success;
9+ gboolean success = FALSE;
10
11 self->bus_name = g_path_get_basename (self->service_file);
12

Subscribers

People subscribed via source and target branches