Merge lp:~larsu/indicator-sound/rename-blocking-icon into lp:indicator-sound/14.04

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 426
Merged at revision: 427
Proposed branch: lp:~larsu/indicator-sound/rename-blocking-icon
Merge into: lp:indicator-sound/14.04
Diff against target: 12 lines (+1/-1)
1 file modified
src/service.vala (+1/-1)
To merge this branch: bzr merge lp:~larsu/indicator-sound/rename-blocking-icon
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211786@code.launchpad.net

Commit message

Use audio-volume-mute-blocking-panel instead of *-blocked-panel

Description of the change

Use audio-volume-mute-blocking-panel instead of *-blocked-panel

blocked is in Humanity and blocking is in ubuntu-mono. Simon fixed the icon in ubuntu-mono to be red instead of blue: lp:~ochosi/ubuntu-themes/audio-volume-blocking

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

that's better indeed (theme update landed in trusty today)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/service.vala'
2--- src/service.vala 2014-03-18 10:00:51 +0000
3+++ src/service.vala 2014-03-19 17:23:35 +0000
4@@ -188,7 +188,7 @@
5 double volume = this.volume_control.get_volume ();
6 string icon;
7 if (this.volume_control.mute)
8- icon = this.mute_blocks_sound ? "audio-volume-muted-blocked-panel" : "audio-volume-muted-panel";
9+ icon = this.mute_blocks_sound ? "audio-volume-muted-blocking-panel" : "audio-volume-muted-panel";
10 else if (volume <= 0.0)
11 icon = "audio-volume-low-zero-panel";
12 else if (volume <= 0.3)

Subscribers

People subscribed via source and target branches