Merge lp:~larsu/indicator-messages/show-separators into lp:indicator-messages/12.10
Proposed by
Lars Karlitski
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Lars Karlitski | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~larsu/indicator-messages/show-separators | ||||
Merge into: | lp:indicator-messages/12.10 | ||||
Diff against target: |
102 lines (+12/-21) 3 files modified
configure.ac (+1/-1) src/indicator-messages.c (+9/-19) src/messages-service.c (+2/-1) |
||||
To merge this branch: | bzr merge lp:~larsu/indicator-messages/show-separators | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
jenkins (community) | continuous-integration | Needs Fixing | |
Review via email: mp+124298@code.launchpad.net |
Commit message
Show menu separators between sections
Previously, gtk didn't support changing the menu model on an already-created
GtkMenu. Since IndicatorObject doesn't allow changing the GtkMenu it exports
to the panel, IndicatorMessages created a menu with a single section, into
which the menu from the service was inserted (and removed when the service
died). This led to seperators not being shown, because separators are only
shown between top-level sections.
Gtk now has gtk_menu_
wrapper section.
Description of the change
Show menu separators between sections. Depends on a gtk+ patch [1] which will land in gtk+ very soon.
To post a comment you must log in.
FAILED: Continuous integration, rev:313 jenkins. qa.ubuntu. com/job/ indicator- messages- ci/16/ jenkins. qa.ubuntu. com/job/ indicator- messages- ci/./label= quantal/ 16/console
http://
Executed test runs:
FAILURE: http://