Merge lp:~larsu/indicator-messages/set-targets into lp:indicator-messages/14.04

[Lars Karlitski]

phone menu: set action targets on source and message menu items

[Nick Dedekind (nick-dedekind)]

LGTM
tested and works

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:400
http://jenkins.qa.ubuntu.com/job/indicator-messages-ci/111/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-armhf-ci/6/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-messages-ci/111/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-messages-autolanding/47/
Executed test runs:
    FAILURE: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3631/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-amd64-autolanding/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-armhf-autolanding/6/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:401
http://jenkins.qa.ubuntu.com/job/indicator-messages-ci/112/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-armhf-ci/7
        deb: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-armhf-ci/7/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-messages-ci/112/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:400
http://jenkins.qa.ubuntu.com/job/indicator-messages-ci/113/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/indicator-messages-trusty-armhf-ci/8/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-messages-ci/113/rebuild

review: Approve (continuous-integration)

=== modified file 'm4/gcov.m4'
--- m4/gcov.m4	2012-03-19 18:18:45 +0000
+++ m4/gcov.m4	2013-12-13 15:43:42 +0000
@@ -30,7 +30,7 @@
     AC_MSG_ERROR([ccache must be disabled when --enable-gcov option is used. You can disable ccache by setting environment variable CCACHE_DISABLE=1.])
   fi
 
-  lcov_version_list="1.6 1.7 1.8 1.9"
+  lcov_version_list="1.6 1.7 1.8 1.9 1.10"
   AC_CHECK_PROG(LCOV, lcov, lcov)
   AC_CHECK_PROG(GENHTML, genhtml, genhtml)
 

=== modified file 'src/im-phone-menu.c'
--- src/im-phone-menu.c	2013-10-02 10:54:52 +0000
+++ src/im-phone-menu.c	2013-12-13 15:43:42 +0000
@@ -186,7 +186,7 @@
   action_name = g_strconcat (app_id, ".msg.", id, NULL);
 
   item = g_menu_item_new (title, NULL);
-  g_menu_item_set_action_and_target_value (item, action_name, NULL);
+  g_menu_item_set_action_and_target_value (item, action_name, g_variant_new_boolean (TRUE));
 
   g_menu_item_set_attribute (item, "x-canonical-type", "s", "com.canonical.indicator.messages.messageitem");
   g_menu_item_set_attribute (item, "x-canonical-message-id", "s", id);
@@ -256,7 +256,7 @@
   action_name = g_strconcat (app_id, ".src.", id, NULL);
 
   item = g_menu_item_new (label, NULL);
-  g_menu_item_set_action_and_target_value (item, action_name, NULL);
+  g_menu_item_set_action_and_target_value (item, action_name, g_variant_new_boolean (TRUE));
   g_menu_item_set_attribute (item, "x-canonical-type", "s", "com.canonical.indicator.messages.sourceitem");
 
   if (iconstr)