Merge lp:~larsu/indicator-messages/lp1231435 into lp:~indicator-applet-developers/indicator-messages/trunk.13.10

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 380
Merged at revision: 381
Proposed branch: lp:~larsu/indicator-messages/lp1231435
Merge into: lp:~indicator-applet-developers/indicator-messages/trunk.13.10
Diff against target: 11 lines (+1/-1)
1 file modified
src/im-application-list.c (+1/-1)
To merge this branch: bzr merge lp:~larsu/indicator-messages/lp1231435
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+187809@code.launchpad.net

Commit message

im-application-list: show all sources that have a count, time, or non-empty string

Description of the change

im-application-list: show all sources that have a count, time, or non-empty string

This is a regression introduced with the branch consolidation.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems fine to me and makes xchat-gnome happy!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/im-application-list.c'
2--- src/im-application-list.c 2013-09-12 11:30:04 +0000
3+++ src/im-application-list.c 2013-09-26 14:56:49 +0000
4@@ -830,7 +830,7 @@
5 g_action_group_change_action_state (G_ACTION_GROUP (app->source_actions), id,
6 g_variant_new ("(uxsb)", count, time, string, draws_attention));
7
8- visible = count > 0;
9+ visible = count > 0 || time != 0 || (string != NULL && string[0] != '\0');
10
11 g_signal_emit (app->list, signals[SOURCE_CHANGED], 0, app->id, id, label, serialized_icon, visible);
12

Subscribers

People subscribed via source and target branches