Merge lp:~larsu/indicator-messages/lp1215644 into lp:~indicator-applet-developers/indicator-messages/trunk.13.10

Proposed by Lars Karlitski
Status: Merged
Approved by: Ted Gould
Approved revision: 372
Merged at revision: 372
Proposed branch: lp:~larsu/indicator-messages/lp1215644
Merge into: lp:~indicator-applet-developers/indicator-messages/trunk.13.10
Diff against target: 20 lines (+2/-1)
1 file modified
libmessaging-menu/messaging-menu-message.c (+2/-1)
To merge this branch: bzr merge lp:~larsu/indicator-messages/lp1215644
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+182980@code.launchpad.net

Description of the change

libmessaging-menu: default MessagingMenuMessage::draws-attention to TRUE

In most cases, apps will want to draw the user's attention when they add a message to the menu.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Nice fix :-)

review: Approve
Revision history for this message
Omer Akram (om26er) wrote :

I tried this change, but the issue is still there on my phone.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libmessaging-menu/messaging-menu-message.c'
2--- libmessaging-menu/messaging-menu-message.c 2013-08-20 10:39:46 +0000
3+++ libmessaging-menu/messaging-menu-message.c 2013-08-29 18:28:59 +0000
4@@ -241,7 +241,7 @@
5
6 properties[PROP_DRAWS_ATTENTION] = g_param_spec_boolean ("draws-attention", "Draws attention",
7 "Whether the message should draw attention",
8- FALSE,
9+ TRUE,
10 G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
11
12 g_object_class_install_properties (klass, NUM_PROPERTIES, properties);
13@@ -270,6 +270,7 @@
14 static void
15 messaging_menu_message_init (MessagingMenuMessage *self)
16 {
17+ self->draws_attention = TRUE;
18 }
19
20 /**

Subscribers

People subscribed via source and target branches