Merge lp:~larsu/indicator-messages/fix-blacklist into lp:indicator-messages/0.3
Proposed by
Lars Karlitski
Status: | Merged |
---|---|
Approved by: | Ted Gould |
Approved revision: | 253 |
Merged at revision: | 259 |
Proposed branch: | lp:~larsu/indicator-messages/fix-blacklist |
Merge into: | lp:indicator-messages/0.3 |
Diff against target: |
99 lines (+22/-23) 1 file modified
src/messages-service.c (+22/-23) |
To merge this branch: | bzr merge lp:~larsu/indicator-messages/fix-blacklist |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+94424@code.launchpad.net |
Description of the change
The blacklist hash map used desktop file contents as keys, but checked for file paths when checking whether an etnry should be hidden. This patch makes it use the link target, which should be something in /usr/share/
I'm not sure about this approach though. Maybe someone with more insight into i-messages can tell me whether this makes sense at all.
Also, hidden menuitems are still visible for me (only the label is gone). A bug in libindicator?
To post a comment you must log in.
I think that instead of using the symlink targets we should probably use basename's to match the desktop file names. I think that some people might have done a copy of the desktop files instead of linking them, while I think linking would be better, I don't think we can use that alone.