lp:~larsu/indicator-messages/blue

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~indicator-applet-developers/indicator-messages/trunk.13.10 at revision 391

Ted Gould (community): Approve on 2013-10-04

PS Jenkins bot (community): Approve (continuous-integration) on 2013-10-04

Diff: 215 lines (+55/-40)

2 files modified

src/im-application-list.c (+52/-39)
src/im-desktop-menu.c (+3/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1215644: Messaging menu does not change icon when a new message appears

Undecided

Fix Released

Link a bug report

Related blueprints

395. By Lars Karlitski on 2013-10-04

app_source_action_check_draw: flip erroneous != to ==

394. By Lars Karlitski on 2013-10-04

Add "visible" paramete to im-application-list-source-added

393. By Lars Karlitski on 2013-10-04

im-application-list: fix draws_attention logic

The logic to update the both the global and the application-specific
draws_attention flags was wrong or inefficient (sending unnecessary updates)
when adding, removing, and modifying sources and messages.

392. By Lars Karlitski on 2013-10-04

app_source_action_check_draw: reset app->draws_attention

Fixes a bug: if a source drawing attention is removed, this function would
leave app->draws_attention set to TRUE.

391. By Lars Karlitski on 2013-10-04

app_source_action_check_draw: don't let invisible sources draw attention

390. By Lars Karlitski on 2013-10-04

Rename app_check_draw_attention to app_update_draws_attention

Because it doesn't check the flag, it updates it. Also make the function return
whether the flag was changed.

389. By Lars Karlitski on 2013-10-04

app_check_draw_attention: don't overwrite draws_attention when it is already TRUE

388. By Charles Kerr on 2013-10-03

in im_application_list_update_draws_attention(), free the temporary icon_name string created by g_strdup_printf(). Fixes: https://bugs.launchpad.net/bugs/1234895.

Approved by Ted Gould, PS Jenkins bot.

387. By Lars Karlitski on 2013-10-02

Return values from functions that have return values.

Somehow -Wreturn-type warnings aren't always triggered for g_return_if_fail macros.

Approved by Ted Gould, PS Jenkins bot.

386. By Lars Karlitski on 2013-10-02

Remove 'indicator.' from the "Clear All" menu item on the phone's menu.

Approved by PS Jenkins bot, Nick Dedekind.