Merge lp:~larsu/indicator-messages/arch-dependent-libdir into lp:~indicator-applet-developers/indicator-messages/trunk.13.10

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 378
Merged at revision: 376
Proposed branch: lp:~larsu/indicator-messages/arch-dependent-libdir
Merge into: lp:~indicator-applet-developers/indicator-messages/trunk.13.10
Diff against target: 83 lines (+9/-9)
8 files modified
data/Makefile.am (+1/-1)
data/indicator-messages.service.in (+1/-1)
debian/gir1.2-messagingmenu-1.0.install (+1/-1)
debian/indicator-messages.install (+1/-1)
debian/libmessaging-menu-dev.install (+2/-2)
debian/libmessaging-menu0.install (+1/-1)
debian/rules (+1/-1)
src/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~larsu/indicator-messages/arch-dependent-libdir
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sebastien Bacher Approve
Review via email: mp+184281@code.launchpad.net

Description of the change

Install into /usr/lib/$arch, to be consistent with the other indicators

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, I don't think the gir stack handles multiarch though (e.g that's likely to make the gir not work)...

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

sorry, I didn't notice at first that the .install was installing those in /usr/lib ... seems good ;-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/Makefile.am'
2--- data/Makefile.am 2013-08-20 10:38:10 +0000
3+++ data/Makefile.am 2013-09-06 12:03:38 +0000
4@@ -4,7 +4,7 @@
5 dbus_services_DATA = indicator-messages.service
6
7 %.service: %.service.in
8- sed -e "s|\@libexecdir\@|$(libexecdir)|" $< > $@
9+ sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
10
11 gsettings_SCHEMAS = com.canonical.indicator.messages.gschema.xml
12 @GSETTINGS_RULES@
13
14=== modified file 'data/indicator-messages.service.in'
15--- data/indicator-messages.service.in 2011-01-27 23:00:31 +0000
16+++ data/indicator-messages.service.in 2013-09-06 12:03:38 +0000
17@@ -1,3 +1,3 @@
18 [D-BUS Service]
19 Name=com.canonical.indicator.messages
20-Exec=@libexecdir@/indicator-messages-service
21+Exec=@pkglibexecdir@/indicator-messages-service
22
23=== modified file 'debian/gir1.2-messagingmenu-1.0.install'
24--- debian/gir1.2-messagingmenu-1.0.install 2012-08-23 11:28:52 +0000
25+++ debian/gir1.2-messagingmenu-1.0.install 2013-09-06 12:03:38 +0000
26@@ -1,1 +1,1 @@
27-usr/lib/girepository-1.0/*.typelib
28+usr/lib/*/girepository-1.0 /usr/lib
29
30=== modified file 'debian/indicator-messages.install'
31--- debian/indicator-messages.install 2013-08-20 10:38:10 +0000
32+++ debian/indicator-messages.install 2013-09-06 12:03:38 +0000
33@@ -1,4 +1,4 @@
34-usr/lib/indicator-messages/indicator-messages-service
35+usr/lib/*/indicator-messages/indicator-messages-service
36 usr/share/dbus-1
37 usr/share/glib-2.0
38 usr/share/icons
39
40=== modified file 'debian/libmessaging-menu-dev.install'
41--- debian/libmessaging-menu-dev.install 2013-08-20 10:38:10 +0000
42+++ debian/libmessaging-menu-dev.install 2013-09-06 12:03:38 +0000
43@@ -1,5 +1,5 @@
44-usr/lib/libmessaging-menu.so
45-usr/lib/pkgconfig
46+usr/lib/*/libmessaging-menu.so
47+usr/lib/*/pkgconfig
48 usr/include /usr/
49 usr/share/gir-1.0/
50 usr/share/vala/
51
52=== modified file 'debian/libmessaging-menu0.install'
53--- debian/libmessaging-menu0.install 2012-08-23 11:28:52 +0000
54+++ debian/libmessaging-menu0.install 2013-09-06 12:03:38 +0000
55@@ -1,1 +1,1 @@
56-usr/lib/libmessaging-menu.so.* /usr/lib/
57+usr/lib/*/libmessaging-menu.so.*
58
59=== modified file 'debian/rules'
60--- debian/rules 2012-11-13 18:45:32 +0000
61+++ debian/rules 2013-09-06 12:03:38 +0000
62@@ -9,7 +9,7 @@
63 NO_CONFIGURE=1 dh_autoreconf ./autogen.sh
64
65 override_dh_auto_configure:
66- dh_auto_configure -- --libdir="\$${prefix}/lib" --libexecdir="\$${prefix}/lib/indicator-messages" --enable-gtk-doc
67+ dh_auto_configure -- --enable-gtk-doc
68
69 override_dh_install:
70 find debian/tmp/usr/lib -name *.la -delete
71
72=== modified file 'src/Makefile.am'
73--- src/Makefile.am 2013-08-28 10:23:31 +0000
74+++ src/Makefile.am 2013-09-06 12:03:38 +0000
75@@ -1,7 +1,7 @@
76
77 EXTRA_DIST =
78
79-libexec_PROGRAMS = indicator-messages-service
80+pkglibexec_PROGRAMS = indicator-messages-service
81
82 indicator_messages_service_SOURCES = \
83 messages-service.c \

Subscribers

People subscribed via source and target branches