Indicator keyboard

Merge lp:~larsu/indicator-keyboard/set-position into lp:indicator-keyboard

  1. set-position
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 117
Merged at revision: 159
Proposed branch: lp:~larsu/indicator-keyboard/set-position
Merge into: lp:indicator-keyboard
Diff against target: 11 lines (+1/-0)
1 file modified
data/Makefile.am (+1/-0)
To merge this branch: bzr merge lp:~larsu/indicator-keyboard/set-position
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
William Hua (community) Approve
Review via email: mp+187050@code.launchpad.net

Description of the change

Set the indicator's position according to http://wiki.ubuntu.com/SystemComponents

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:116
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-ci/24/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-ci/24/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-keyboard-ci/24/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:117
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-ci/25/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-ci/25/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-ci/25
        deb: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-ci/25/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-keyboard-ci/25/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
William Hua (attente) wrote :

According to mpt: "Better that it be in the wrong position in the system status area, than that it not be in the system status area at all."

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-autolanding/16/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2485
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-autolanding/16
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-autolanding/16/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-autolanding/17/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2488
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-autolanding/17/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-autolanding/17
        deb: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-autolanding/17/artifact/work/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-keyboard-autolanding/18/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2497
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-amd64-autolanding/18/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-autolanding/18
        deb: http://jenkins.qa.ubuntu.com/job/indicator-keyboard-saucy-armhf-autolanding/18/artifact/work/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/Makefile.am'
2--- data/Makefile.am 2013-08-07 20:20:23 +0000
3+++ data/Makefile.am 2013-09-23 15:51:55 +0000
4@@ -46,6 +46,7 @@
5 $(AM_V_GEN) (echo '[Indicator Service]'; \
6 echo 'Name=indicator-keyboard'; \
7 echo 'ObjectPath=/com/canonical/indicator/keyboard'; \
8+ echo 'Position=80'; \
9 echo ''; \
10 echo '[desktop]'; \
11 echo 'ObjectPath=/com/canonical/indicator/keyboard/desktop'; \

Subscribers

People subscribed via source and target branches

to all changes: