Merge lp:~larsu/ido/slider-min-size into lp:ido/13.10

Proposed by Lars Karlitski on 2013-10-10
Status: Merged
Approved by: Charles Kerr on 2013-10-10
Approved revision: 152
Merged at revision: 152
Proposed branch: lp:~larsu/ido/slider-min-size
Merge into: lp:ido/13.10
Diff against target: 12 lines (+2/-0)
1 file modified
src/idoscalemenuitem.c (+2/-0)
To merge this branch: bzr merge lp:~larsu/ido/slider-min-size
Reviewer Review Type Date Requested Status
Charles Kerr (community) 2013-10-10 Approve on 2013-10-10
PS Jenkins bot (community) continuous-integration Approve on 2013-10-10
Review via email: mp+190466@code.launchpad.net

Commit message

idoscalemenuitem: request a minimum width of 200px

Description of the change

idoscalemenuitem: request a minimum width of 200px

That's a magic number, but not more magic than the same number in idoplaybackmenuitem.

This fix is needed mostly for the sound menu in the greeter, which doesn't have players items in it that size the menu to an acceptable size. On the desktop, there's probably a player in most of the cases.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/idoscalemenuitem.c'
2--- src/idoscalemenuitem.c 2013-09-24 22:11:13 +0000
3+++ src/idoscalemenuitem.c 2013-10-10 20:03:59 +0000
4@@ -448,6 +448,8 @@
5 IdoScaleMenuItemPrivate *priv = GET_PRIVATE (self);
6
7 priv->reverse_scroll = TRUE;
8+
9+ gtk_widget_set_size_request (GTK_WIDGET (self), 200, -1);
10 }
11
12 static void

Subscribers

People subscribed via source and target branches