Merge lp:~larsu/ido/revert-slider into lp:ido/13.10

Proposed by Lars Karlitski on 2013-09-15
Status: Merged
Approved by: Ted Gould on 2013-09-16
Approved revision: 147
Merged at revision: 147
Proposed branch: lp:~larsu/ido/revert-slider
Merge into: lp:ido/13.10
Diff against target: 22 lines (+4/-1)
1 file modified
src/idoscalemenuitem.c (+4/-1)
To merge this branch: bzr merge lp:~larsu/ido/revert-slider
Reviewer Review Type Date Requested Status
Ted Gould (community) 2013-09-15 Approve on 2013-09-16
PS Jenkins bot (community) continuous-integration Approve on 2013-09-15
Review via email: mp+185680@code.launchpad.net

Commit message

Reverse slider movement when scrolling by default

Description of the change

Revert slider movement when scrolling by default

This makes scroll direction for sliders in ido behave more like the expectation of most users (anecdotally), like it does for the sound indicator itself, and like the sliders in the sound panel.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Ted Gould (ted) wrote :

Works. My argument would be that you should be able to use the scroll wheel the same on the slider as the icon. This makes them match up, which seems logical.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/idoscalemenuitem.c'
2--- src/idoscalemenuitem.c 2013-07-03 02:13:03 +0000
3+++ src/idoscalemenuitem.c 2013-09-15 18:27:00 +0000
4@@ -307,7 +307,7 @@
5 g_param_spec_boolean ("reverse-scroll-events",
6 "Reverse scroll events",
7 "Reverses how up/down scroll events are interpreted",
8- FALSE,
9+ TRUE,
10 G_PARAM_READWRITE));
11
12 /**
13@@ -411,6 +411,9 @@
14 static void
15 ido_scale_menu_item_init (IdoScaleMenuItem *self)
16 {
17+ IdoScaleMenuItemPrivate *priv = GET_PRIVATE (self);
18+
19+ priv->reverse_scroll = TRUE;
20 }
21
22 static void

Subscribers

People subscribed via source and target branches