lp:~larsu/ido/remove-slider-hack-953757

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ido/12.10

jenkins (community): Needs Fixing (continuous-integration) on 2012-08-27

Charles Kerr (community): Approve on 2012-08-27

Diff: 55 lines (+6/-19) (has conflicts)

2 files modified

src/idorange.c (+2/-0)
src/idoscalemenuitem.c (+4/-19)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #953757: Inconsistent behavior of slider widgets

Undecided

Fix Released

Link a bug report

Related blueprints

108. By Lars Karlitski on 2012-03-16

ido-range: chain up constructed() to base class

107. By Lars Karlitski on 2012-03-16

Remove slider mouse button hack

This should be a global setting for all sliders and fixed in gtk.

106. By Charles Kerr on 2012-03-14

fix regression that broke mousewheel operations on the idoscale

105. By Charles Kerr on 2012-03-13

0.3.3

104. By Charles Kerr on 2012-03-13

merge lp:~charlesk/ido/lp-898611 to fix lp bug #898611

103. By Charles Kerr on 2012-03-12

Merge lp:~charlesk/indicator-sound/lp-921065 into lp:indicator-sound to add "primary-clicked" and "secondary-clicked" events for lp bug #921065

102. By Charles Kerr on 2012-03-12

Merge lp:~charlesk/ido/lp-906050 into lp:ido to resolve the following LP tickets:

Bug #524541: Volume (slider) item isn't highlighted when selected
Bug #886335: Unable to use arrow keys to adjust the volume control in the sound menu.
Bug #906050: Playback controls don't highlight anything like other menu items

101. By Ted Gould on 2012-03-09

0.3.2

100. By Ken VanDine on 2012-02-09

add style class "menubar" to the offscreen proxy, this fixes the white background drawn in the sound menu menu with the current gtk3/light-themes (LP: #925700)

99. By Ken VanDine on 2012-01-11

Patch from ~covox (LP: #867649)

In method ido_offscreen_proxy_realize(), a call is made to gdk_screen_get_rgba_visual() to get a GdkVisual handle, which is then passed as part of a GdkWindowAttr structure to gdk_window_new().

What's not taken into account is that gdk_screen_get_rgba_visual() will return NULL if RGBA isn't supported by the destination window manager (e.g. if someone turned the Composite extension off). In this case, as the field is always marked as valid for use (GDK_WA_VISUAL), gdk_window_new will fall over.

Attached is a patch to fall back on gdk_screen_get_system_visual() if RGBA isn't available. With this, unity-panel-service no longer crashes after interacting with the Sound indicator if the Composite extension is switched off.