lp:~larsu/ido/lp1246536

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ido/14.04 at revision 156

Charles Kerr (community): Approve on 2013-10-31

PS Jenkins bot (community): Approve (continuous-integration) on 2013-10-31

Diff: 67 lines (+14/-21)

1 file modified

src/idoscalemenuitem.c (+14/-21)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1246536: segfault in menu_hidden()

High

Fix Released

Link a bug report

Related blueprints

156. By Lars Karlitski on 2013-10-31

idoscalemenuitem: disconnect signal from parent

This fixes a crash: the widget installed a handler for the parent's hide
signal, but was destroyed before the parent without disconnecting the signal.

This patch also moves the connection into GktWidget.parent_set instead of
connecting to the notify signal.

155. By Lars Karlitski on 2013-10-28

IdoUserMenuItem: only allow file icons as avatars

In practice, all avatars are file icons. This restriction allowed for quite some cleanup, as we don't need to worry about symbolic icons and themes aymore.

Note: this patch removes the warning when the user avatar image was not found. This is a common enough case that the warning just clutters up logs.

Approved by Charles Kerr, PS Jenkins bot.

154. By Lars Karlitski on 2013-10-22

Make IdoSwitchMenuItem accessible from gtk_menu_new_from_model.

Approved by Charles Kerr, PS Jenkins bot.

153. By PS Jenkins bot on 2013-10-11

Releasing 13.10.0+13.10.20131011-0ubuntu1 (revision 152 from lp:ido).

Approved by PS Jenkins bot.

152. By Lars Karlitski on 2013-10-10

idoscalemenuitem: request a minimum width of 200px.

Approved by Charles Kerr, PS Jenkins bot.

151. By Lars Karlitski on 2013-09-30

idousermenuitem: center avatar and adjust spacing.

Approved by Sebastien Bacher, PS Jenkins bot.

150. By PS Jenkins bot on 2013-09-30

Releasing 13.10.0+13.10.20130930-0ubuntu1 (revision 149 from lp:ido).

Approved by PS Jenkins bot.

149. By Lars Karlitski on 2013-09-25

idoscalemenuitem: don't update the action state when the action state changes

GtkRange has the same weird semantics for its "value-changed" signal that the check menu items have: it is emitted not only on user interaction, but also when gtk_range_set_value() is called.

The handler to "value-changed" updates the action. gtk_range_set_value() is called when the action notifies about a state change. Loop, meet loop.

This patch works around that by adding a "value-changed" to IdoScaleMenuItem that is only emitted when the user changes the slider's value.
. Fixes: https://bugs.launchpad.net/bugs/1229076.

Approved by Ted Gould, PS Jenkins bot.

148. By PS Jenkins bot on 2013-09-20

Releasing 13.10.0+13.10.20130920-0ubuntu1 (revision 147 from lp:ido).

Approved by PS Jenkins bot.

147. By Lars Karlitski on 2013-09-16

Reverse slider movement when scrolling by default. Fixes: https://bugs.launchpad.net/bugs/1225330.

Approved by Ted Gould, PS Jenkins bot.