Merge lp:~larsu/ido/dont-set-spinner into lp:ido/15.04

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 189
Merged at revision: 189
Proposed branch: lp:~larsu/ido/dont-set-spinner
Merge into: lp:ido/15.04
Diff against target: 11 lines (+0/-2)
1 file modified
src/idoplaybackmenuitem.c (+0/-2)
To merge this branch: bzr merge lp:~larsu/ido/dont-set-spinner
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+248119@code.launchpad.net

Commit message

idoplaybackmenuitem: don't set the spinner class

Spinners are drawn in css now and hidden when they're inactive, but the playback controls should always be shown. Themes will need to style them separately.

Description of the change

idoplaybackmenuitem: don't set the spinner class

Spinners are drawn in css now and hidden when they're inactive, but the playback controls should always be shown. Themes will need to style them separately.

To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/idoplaybackmenuitem.c'
2--- src/idoplaybackmenuitem.c 2014-04-23 14:37:18 +0000
3+++ src/idoplaybackmenuitem.c 2015-01-30 14:09:45 +0000
4@@ -358,8 +358,6 @@
5 static void
6 ido_playback_menu_item_init (IdoPlaybackMenuItem *self)
7 {
8- gtk_style_context_add_class (gtk_widget_get_style_context (GTK_WIDGET (self)), GTK_STYLE_CLASS_SPINNER);
9-
10 gtk_widget_set_size_request (GTK_WIDGET (self), 200, 43);
11 }
12

Subscribers

People subscribed via source and target branches