Code review comment for lp:~larsu/gsettings-qt/lp1503693

Revision history for this message
Lars Karlitski (larsu) wrote :

> any reason you removed the signalspy? i think it's good checking that reset
> does actually trigger the signal too, proves that qml will re-evaluate things
> that depend on it, something like
>
> changesSpy.clear();
> settings.schema.reset('testInteger');
> tryCompare(changesSpy, "count", 1);
>
> What do you think?

Good point. I removed it because it was counting the emitted signals for all tests. Didn't think about looking at the docs to find something like "clear". Thanks!

« Back to merge proposal