lp:~larsu/evolution-indicator/messaging-menu-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp:evolution-indicator

Mathieu Trudel-Lapierre: Pending requested 2013-03-21

Diff: 993 lines (+172/-550)

3 files modified

configure.ac (+1/-1)
src/evolution-indicator.c (+169/-548)
src/org-freedesktop-evolution-indicator.eplug.xml (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

103. By Lars Karlitski on 2013-03-21

Use new-style GtkBox constructors

102. By Lars Karlitski on 2013-03-21

Declare update_unity_launcher_count before first use

101. By Lars Karlitski on 2013-03-21

e_plugin_get_configure_widget: return NULL instead of an empty widget

To get rid of warnings about deprecated gtk functions.

100. By Lars Karlitski on 2013-03-21

Use GMutex instead of the deprecated GStaticMutex

99. By Lars Karlitski on 2013-03-21

Update the list of accounts on-the-fly

We don't need any information about sources until new messages arrive. Create
the account objects then, instead of listening to "source-added" and
"source-removed" signals.

98. By Lars Karlitski on 2013-03-21

Remove n_accounts global variable

It gets in the way of the next patch.

97. By Lars Karlitski on 2013-03-21

Use evolution's uids instead of self-assembled urls as message source identifiers

This simplifies the code and fixes a bug: all POP accounts got the url "pop:",
making them show up as the same entry in the messaging menu.

96. By Lars Karlitski on 2013-03-21

update_accounts: fix memory leak

95. By Lars Karlitski on 2013-03-21

update_accounts: move name and url fetching into separate function

Also removes some unnecessary string allocations and a memory leak.

94. By Lars Karlitski on 2013-03-21

update_accounts: recreate accounts list from scratch

This function is only ever called when the global 'accounts' list is NULL,
there's no need to check for existing accounts.