Merge lp:~larsu/evince/lp1312179 into lp:~ubuntu-desktop/evince/ubuntu

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 242
Merged at revision: 243
Proposed branch: lp:~larsu/evince/lp1312179
Merge into: lp:~ubuntu-desktop/evince/ubuntu
Diff against target: 54 lines (+20/-13)
1 file modified
debian/patches/0002-Don-t-use-gtk_application_set_accels_for_action.patch (+20/-13)
To merge this branch: bzr merge lp:~larsu/evince/lp1312179
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
VCS imports Pending
Review via email: mp+217615@code.launchpad.net

This proposal supersedes a proposal from 2014-04-29.

Description of the change

menu patch: allow detailed action names in the set_accels_for_action case

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/0002-Don-t-use-gtk_application_set_accels_for_action.patch'
2--- debian/patches/0002-Don-t-use-gtk_application_set_accels_for_action.patch 2014-02-10 17:43:04 +0000
3+++ debian/patches/0002-Don-t-use-gtk_application_set_accels_for_action.patch 2014-04-29 14:20:41 +0000
4@@ -14,23 +14,33 @@
5 shell/menus.ui | 22 ++++++++++++++++++++++
6 2 files changed, 23 insertions(+), 1 deletion(-)
7
8-diff --git a/shell/ev-application.c b/shell/ev-application.c
9-index e2d87af..2c4b7b3 100644
10---- a/shell/ev-application.c
11-+++ b/shell/ev-application.c
12-@@ -1176,7 +1176,7 @@ ev_application_startup (GApplication *gapplication)
13+Index: evince-3.10.3/shell/ev-application.c
14+===================================================================
15+--- evince-3.10.3.orig/shell/ev-application.c 2014-04-29 16:09:07.319931409 +0200
16++++ evince-3.10.3/shell/ev-application.c 2014-04-29 16:09:33.031931585 +0200
17+@@ -1193,7 +1193,17 @@
18 it = action_accels;
19 while (it[0])
20 {
21 - gtk_application_set_accels_for_action (GTK_APPLICATION (application), it[0], &it[1]);
22-+ gtk_application_add_accelerator (GTK_APPLICATION (application), it[1], it[0], NULL);
23++ gchar *action;
24++ GVariant *target;
25++
26++ if (g_action_parse_detailed_name (it[0], &action, &target, NULL))
27++ {
28++ gtk_application_add_accelerator (GTK_APPLICATION (application), it[1], action, target);
29++
30++ g_free (action);
31++ if (target)
32++ g_variant_unref (target);
33++ }
34 it += g_strv_length ((gchar **) it) + 1;
35 }
36 }
37-diff --git a/shell/menus.ui b/shell/menus.ui
38-index c3006f8..1d9a32e 100644
39---- a/shell/menus.ui
40-+++ b/shell/menus.ui
41+Index: evince-3.10.3/shell/menus.ui
42+===================================================================
43+--- evince-3.10.3.orig/shell/menus.ui 2014-04-29 16:09:07.319931409 +0200
44++++ evince-3.10.3/shell/menus.ui 2014-04-29 16:09:07.311931409 +0200
45 @@ -23,6 +23,7 @@
46 <item>
47 <attribute name="label" translatable="yes">_Open</attribute>
48@@ -181,6 +191,3 @@
49 </item>
50 </section>
51 <section>
52---
53-1.9.rc1
54-

Subscribers

People subscribed via source and target branches

to all changes: