Merge lp:~larstiq/bzr/bug957049 into lp:bzr/2.5

Proposed by Wouter van Heyst
Status: Merged
Merged at revision: 6506
Proposed branch: lp:~larstiq/bzr/bug957049
Merge into: lp:bzr/2.5
Diff against target: 19 lines (+2/-0)
1 file modified
bzrlib/ (+2/-0)
To merge this branch: bzr merge lp:~larstiq/bzr/bug957049
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
bzr-core Pending
Review via email:

Description of the change

Bug 957049 is about bzr config not dealing with directory services. I've added a derefence at the start of cmd_config, but I need some help with how to test it correctly.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I would probably register a custom directory service during the test (don't we already have a dummy directory service somewhere?) and then use that to test that 'bzr config' does the right thing.

Revision history for this message
Martin Packman (gz) wrote :

Let's just land this if it's been manually tested rather than blocking on having unit tests.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzrlib/'
--- bzrlib/ 2012-03-26 17:01:21 +0000
+++ bzrlib/ 2012-04-30 08:19:19 +0000
@@ -88,6 +88,7 @@
88 atomicfile,88 atomicfile,
89 controldir,89 controldir,
90 debug,90 debug,
91 directory_service,
91 errors,92 errors,
92 lazy_regex,93 lazy_regex,
93 library_state,94 library_state,
@@ -4003,6 +4004,7 @@
4003 remove=False):4004 remove=False):
4004 if directory is None:4005 if directory is None:
4005 directory = '.'4006 directory = '.'
4007 directory = directory_service.directories.dereference(directory)
4006 directory = urlutils.normalize_url(directory)4008 directory = urlutils.normalize_url(directory)
4007 if remove and all:4009 if remove and all:
4008 raise errors.BzrError(4010 raise errors.BzrError(


People subscribed via source and target branches