Merge ~larsks/cloud-init:bug/cloudstack-tests into cloud-init:master

[Lars Kellogg-Stedman]

cloudstack: fix tests to avoid accessing /var/lib/NetworkManager

on centos/fedora/rhel, /var/lib/NetworkManager has mode 700, causing
the cloudstack unit tests to fail when run as a non-root user. This
mocks out get_latest_lease so that we no longer try to read dhcp lease
information during the unit tests.

This permits the unit tests to complete on centos/fedora/rhel/etc.

[Scott Moser (smoser)]

review: Approve

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:afdddf8eea34866b43d1fc92624f9ac175802f36
https://jenkins.ubuntu.com/server/job/cloud-init-ci/353/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/353
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/353
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-ppc64el/353
    SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-i386/353

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/353/rebuild

review: Approve (continuous-integration)

diff --git a/tests/unittests/test_datasource/test_cloudstack.py b/tests/unittests/test_datasource/test_cloudstack.py
index 1d3d2f1..e94aad6 100644
--- a/tests/unittests/test_datasource/test_cloudstack.py
+++ b/tests/unittests/test_datasource/test_cloudstack.py
@@ -16,10 +16,15 @@ class TestCloudStackPasswordFetching(TestCase):
         self.patches.enter_context(mock.patch('{0}.ec2'.format(mod_name)))
         self.patches.enter_context(mock.patch('{0}.uhelp'.format(mod_name)))
         default_gw = "192.201.20.0"
-        mod_name = 'cloudinit.sources.DataSourceCloudStack.get_default_gateway'
+        get_latest_lease = mock.MagicMock(return_value=None)
+        self.patches.enter_context(mock.patch(
+            'cloudinit.sources.DataSourceCloudStack.get_latest_lease',
+            get_latest_lease))
+
         get_default_gw = mock.MagicMock(return_value=default_gw)
-        self.patches.enter_context(
-            mock.patch(mod_name, get_default_gw))
+        self.patches.enter_context(mock.patch(
+            'cloudinit.sources.DataSourceCloudStack.get_default_gateway',
+            get_default_gw))
 
     def _set_password_server_response(self, response_string):
         subp = mock.MagicMock(return_value=(response_string, ''))