Merge lp:~lars.duesing/ubuntu/precise/aiccu/aiccu-upstart-server-patch-precise into lp:ubuntu/precise/aiccu

Proposed by Lars Düsing
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~lars.duesing/ubuntu/precise/aiccu/aiccu-upstart-server-patch-precise
Merge into: lp:ubuntu/precise/aiccu
Diff against target: 80 lines (+47/-2)
4 files modified
debian/aiccu.install (+1/-0)
debian/aiccu.py (+26/-0)
debian/aiccu.upstart (+2/-2)
debian/changelog (+18/-0)
To merge this branch: bzr merge lp:~lars.duesing/ubuntu/precise/aiccu/aiccu-upstart-server-patch-precise
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+111610@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/aiccu.install'
2--- debian/aiccu.install 2010-01-06 10:02:24 +0000
3+++ debian/aiccu.install 2012-06-22 15:11:03 +0000
4@@ -1,3 +1,4 @@
5 doc/aiccu.conf usr/share/aiccu/conf-templates
6 debian/brokers.list usr/share/aiccu/conf-templates
7 debian/60aiccu etc/pm/sleep.d
8+debian/aiccu.py usr/share/apport/package-hooks
9
10=== added file 'debian/aiccu.py'
11--- debian/aiccu.py 1970-01-01 00:00:00 +0000
12+++ debian/aiccu.py 2012-06-22 15:11:03 +0000
13@@ -0,0 +1,26 @@
14+from apport.hookutils import *
15+
16+def mask_string (str):
17+ MASK = '##MASKED##'
18+ return str.group(1) + MASK
19+
20+def mask_values(confinfo):
21+ """ strip personal/private information from the conf entries """
22+ pattrn = re.compile ('((username|password|tunnel_id) )(.*)$', re.IGNORECASE)
23+ newReport = ""
24+ for line in confinfo.splitlines():
25+ line = pattrn.sub (mask_string, line)
26+ newReport += line + '\n'
27+ return newReport
28+
29+def add_info(report, ui=None):
30+ attach_file_if_exists(report, '/var/log/aiccu.log', key='var.log.aiccu.log')
31+ attach_file_if_exists(report, '/etc/aiccu.conf', key='etc.aiccu.conf')
32+ try:
33+ report['etc.aiccu.conf'] = mask_values(report['etc.aiccu.conf'])
34+ except KeyError:
35+ pass
36+ try:
37+ report['modified.conffile..etc.aiccu.conf'] = mask_values(report['modified.conffile..etc.aiccu.conf'])
38+ except KeyError:
39+ pass
40
41=== modified file 'debian/aiccu.upstart'
42--- debian/aiccu.upstart 2012-04-02 11:40:44 +0000
43+++ debian/aiccu.upstart 2012-06-22 15:11:03 +0000
44@@ -65,8 +65,8 @@
45 # Workaround race with local DNS services
46 server=$(grep "^server" /etc/aiccu.conf | awk '{ print $2 }')
47 if [ -z "$server" ]; then
48- log "No server configuration specified"
49- exit 1
50+ log "No server configuration specified - defaulting to tic.sixxs.net"
51+ server="tic.sixxs.net"
52 fi
53 log "Checking access to $server: "
54 count=0
55
56=== modified file 'debian/changelog'
57--- debian/changelog 2012-04-02 11:40:44 +0000
58+++ debian/changelog 2012-06-22 15:11:03 +0000
59@@ -1,3 +1,21 @@
60+aiccu (20070115-14.1ubuntu3.2) precise-proposed; urgency=low
61+
62+ * upstart-script did not honour default server tic.sixxs.net
63+ (LP: #1007408)
64+
65+ -- Lars Duesing <lars.duesing@camelotsweb.de> Fri, 22 Jun 2012 16:11:05 +0200
66+
67+aiccu (20070115-14.1ubuntu3.1) precise-security; urgency=low
68+
69+ * SECURITY UPDATE: Remove personal data (username, password, tunnel_id)
70+ in apport-reports (LP: #1001432)
71+ - added debian/aiccu.py: added a specialized apport-hook which masks
72+ the data before it is sent to launchpad.
73+ - changed debian/aiccu.install: installs the apport-hook
74+ * Add apport hook for /var/log/aiccu.log
75+
76+ -- Lars Duesing <lars.duesing@camelotsweb.de> Mon, 11 Jun 2012 15:31:22 +0200
77+
78 aiccu (20070115-14.1ubuntu3) precise; urgency=low
79
80 [ Lars Duesing ]

Subscribers

People subscribed via source and target branches

to all changes: