Merge lp:~larryprice/url-dispatcher/appid-with-dots into lp:url-dispatcher/touch-vivid
Proposed by
Ted Gould
Status: | Approved | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Ted Gould | ||||||||||||
Approved revision: | 93 | ||||||||||||
Proposed branch: | lp:~larryprice/url-dispatcher/appid-with-dots | ||||||||||||
Merge into: | lp:url-dispatcher/touch-vivid | ||||||||||||
Diff against target: |
79 lines (+17/-6) 3 files modified
CMakeLists.txt (+4/-5) service/dispatcher.c (+1/-1) tests/app-id-test.cc (+12/-0) |
||||||||||||
To merge this branch: | bzr merge lp:~larryprice/url-dispatcher/appid-with-dots | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+310205@code.launchpad.net |
Commit message
App ID should allow package names with dots.
To post a comment you must log in.
Unmerged revisions
- 93. By Larry Price
-
Adding test
- 92. By Larry Price
-
Accept '.' in appid for libertine apps
Backporting to vivid. Same review.