Merge lp:~larryprice/libertine/selectable-error-text into lp:libertine

[Larry Price]

Make error details selectable and add clipboard button.

Make error details selectable and add clipboard button.

[Libertine CI Bot (libertine-ci-bot)]

PASSED: Continuous integration, rev:264
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/38/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/153
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=default/115
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/115
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=default/115
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=vivid+overlay,testname=default/115
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/115
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=yakkety,testname=default/115
    None: https://jenkins.canonical.com/libertine/job/lp-generic-update-mp/123/console
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/156
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-1-sourcepkg/release=vivid+overlay/141
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-1-sourcepkg/release=xenial+overlay/141
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-1-sourcepkg/release=yakkety/141
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=vivid+overlay/134
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=vivid+overlay/134/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/134
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/134/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=yakkety/134
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=yakkety/134/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=vivid+overlay/134
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=vivid+overlay/134/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/134
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/134/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=yakkety/134
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=yakkety/134/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/38/rebuild

review: Approve (continuous-integration)

[Christopher Townsend (townsend)]

Works well. However, the lines in the popup are not wrapped, so it makes it hard to read as the line is outside the popup box.

review: Needs Fixing

[lp:~larryprice/libertine/selectable-error-text]

265. By Larry Price on 2016-07-06

Adding word wrap to error dialog

[Christopher Townsend (townsend)]

Ok, works well, thanks!

review: Approve

=== modified file 'libertine/qml/GenericErrorDialog.qml'
--- libertine/qml/GenericErrorDialog.qml	2016-05-10 14:55:15 +0000
+++ libertine/qml/GenericErrorDialog.qml	2016-07-06 13:42:24 +0000
@@ -22,11 +22,25 @@
 
 Dialog {
     id: genericErrorDialog
-    property var short_description: null
-    property var details: null
+    property string short_description: ""
+    property string details: ""
 
     title: short_description
-    text: details
+
+    TextEdit {
+        color: UbuntuColors.darkGrey
+        text: details
+        readOnly: true
+        selectByMouse: true
+        wrapMode: TextEdit.WordWrap
+    }
+
+    Button {
+        text: i18n.tr("Copy to Clipboard")
+        onClicked: {
+            Clipboard.push(details)
+        }
+    }
 
     Button {
         text: i18n.tr("Dismiss")