Libertine

Merge lp:~larryprice/libertine/lxd-run-environ into lp:libertine

  1. lxd-run-environ
  2. Merge into devel
Proposed by Larry Price
Status: Merged
Approved by: Christopher Townsend
Approved revision: 410
Merged at revision: 445
Proposed branch: lp:~larryprice/libertine/lxd-run-environ
Merge into: lp:libertine
Diff against target: 12 lines (+1/-1)
1 file modified
python/libertine/LxdContainer.py (+1/-1)
To merge this branch: bzr merge lp:~larryprice/libertine/lxd-run-environ
Reviewer Review Type Date Requested Status
Christopher Townsend Approve
Libertine CI Bot continuous-integration Approve
Review via email: mp+320422@code.launchpad.net

Commit message

LXD needs to forward host environment to container when running arbitrary commands.

Description of the change

LXD needs to forward host environment to container when running arbitrary commands.

To post a comment you must log in.
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:410
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/477/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/870
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/720
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=zesty,testname=default/720
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/720
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=zesty,testname=default/720
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/880
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/872
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/872/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/872
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/872/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/872
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/872/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/872
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/872/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/477/rebuild

review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'python/libertine/LxdContainer.py'
2--- python/libertine/LxdContainer.py 2017-03-08 21:23:54 +0000
3+++ python/libertine/LxdContainer.py 2017-03-20 19:54:21 +0000
4@@ -497,7 +497,7 @@
5 return _lxc_args(self.container_id, command, environ)
6
7 def run_in_container(self, command):
8- return subprocess.Popen(self._lxc_args(command)).wait()
9+ return subprocess.Popen(self._lxc_args(command, os.environ.copy())).wait()
10
11 def start_container(self, home=env_home_path()):
12 if not self._try_get_container():

Subscribers

People subscribed via source and target branches