Merge lp:~larryprice/libertine-scope/full-scope-name into lp:libertine-scope

Proposed by Larry Price
Status: Merged
Approved by: Christopher Townsend
Approved revision: 55
Merged at revision: 59
Proposed branch: lp:~larryprice/libertine-scope/full-scope-name
Merge into: lp:libertine-scope
Diff against target: 36 lines (+3/-5)
2 files modified
scope/apps/action.cpp (+2/-2)
scope/apps/config.h.in (+1/-3)
To merge this branch: bzr merge lp:~larryprice/libertine-scope/full-scope-name
Reviewer Review Type Date Requested Status
Libertine CI Bot continuous-integration Approve
Christopher Townsend Approve
Review via email: mp+301390@code.launchpad.net

Commit message

Use full scope name in canned queries to properly return from Show/Hide actions.

Description of the change

Use full scope name in canned queries to properly return from Show/Hide actions.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

Quick inline comment.

55. By Larry Price

remove SCOPE_PKG

Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, thanks

review: Approve
Revision history for this message
Libertine CI Bot (libertine-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scope/apps/action.cpp'
2--- scope/apps/action.cpp 2016-07-19 20:20:12 +0000
3+++ scope/apps/action.cpp 2016-07-28 16:07:51 +0000
4@@ -53,14 +53,14 @@
5 {
6 hidden_->add(QString::fromStdString(result()["app_id"].get_string()));
7
8- usc::CannedQuery cq(SCOPE_PKG);
9+ usc::CannedQuery cq(FULLY_QUALIFIED_APPS_SCOPE);
10 return usc::ActivationResponse(cq);
11 }
12 else if (action_id_ == "show")
13 {
14 hidden_->remove(QString::fromStdString(result()["app_id"].get_string()));
15
16- usc::CannedQuery cq(SCOPE_PKG);
17+ usc::CannedQuery cq(FULLY_QUALIFIED_APPS_SCOPE);
18 return usc::ActivationResponse(cq);
19 }
20 return usc::ActivationResponse(usc::ActivationResponse::Status::NotHandled);
21
22=== modified file 'scope/apps/config.h.in'
23--- scope/apps/config.h.in 2016-07-19 20:20:12 +0000
24+++ scope/apps/config.h.in 2016-07-28 16:07:51 +0000
25@@ -16,10 +16,8 @@
26 #ifndef LIBERTINE_SCOPE_CONFIG_H_
27 #define LIBERTINE_SCOPE_CONFIG_H_
28
29-const std::string SCOPE_PKG = "@PACKAGE_NAME@";
30+const std::string FULLY_QUALIFIED_APPS_SCOPE = "@FULLY_QUALIFIED_NAME@";
31 const std::string ROOT_DEPT_ID = "root_dept";
32 const std::string HIDDEN_DEPT_ID = "hidden_dept";
33
34 #endif // LIBERTINE_SCOPE_CONFIG_H_
35-
36-

Subscribers

People subscribed via source and target branches