Code review comment for lp:~laney/unity-control-center/wk2

Iain Lane (laney) wrote :

Thanks for the review.

On Wed, Jan 13, 2016 at 06:21:07PM -0000, Sebastien Bacher wrote:
> Review: Needs Fixing
>
> Thanks for the work!
>
> There are some small issues though
>
> * you deleted the gtk_scrolled_window_new () call but kept the sw variable and still use it as "user_data" in the callback which triggers a warning about user_data not being a valid GTK_WIDGET

Ok, fixed, thanks.

>
> * detail and was there before, but "gtk_widget_show_all(" lacks a space before the parenthesis, could you it while you are changing this line? ;-)

Ok.

>
> * the scrollbars have glitches/redraw issues here, do you see that as well? (it might be a webkit2 issue, doesn't do that with the current version though so it's an user experience regression and we should at least have a milestoned bug about it)

It's a WebKit and theme problem. Trevinho was looking at it a while ago.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

« Back to merge proposal