Code review comment for lp:~laney/unity-control-center/wk2

Sebastien Bacher (seb128) wrote :

Thanks for the work!

There are some small issues though

* you deleted the gtk_scrolled_window_new () call but kept the sw variable and still use it as "user_data" in the callback which triggers a warning about user_data not being a valid GTK_WIDGET

* detail and was there before, but "gtk_widget_show_all(" lacks a space before the parenthesis, could you it while you are changing this line? ;-)

* the scrollbars have glitches/redraw issues here, do you see that as well? (it might be a webkit2 issue, doesn't do that with the current version though so it's an user experience regression and we should at least have a milestoned bug about it)

review: Needs Fixing

« Back to merge proposal